Closed (fixed)
Project:
Book access
Version:
1.0.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 May 2023 at 14:02 UTC
Updated:
12 Jul 2024 at 16:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
avpadernoThe usual module description is Hook implementations for the [module name] module. where [module name] is replaced by the module name shown in the .info.yml file.
Code lines are not required to be shorter than 81 characters. Line length and wrapping, part of the Drupal coding standards, says:
(Emphasis is mine.)
That change is not correct for the same reason given for the previous change. Furthermore the
"book_access_default_role_{$rid}_access", array());part must be commented out too.Commented out code must still be indented and formatted as per coding standards.
Why is the call to
select()commented out?Those lines are not correctly indented.
Avoiding lines exceed 80 characters does not mean avoiding they exceed 20 characters.
Periods are not appended to commented out code.
The descriptions are each missing a definite article.
Code lines are not required to be shorter than 81 characters. Line length and wrapping, part of the Drupal coding standards, says:
(Emphasis is mine.)
Class descriptions must not start with The class or Class nor repeat the class name.
The description for a constructor must start with
Constructs a newfollowed by the class name (including its namespace), and end withobject.The class name is also wrong, since that class is
BookAccess.Method declarations must be written in a single line.
I am not sure it makes sense to make that change, since
drupal_write_record()is not implemented in Drupal 9.5.Comment #3
urvashi_vora commentedHi @apaderno, I have made the required changes as per your feedback.
Please review.
Thanks
Comment #4
urvashi_vora commentedComment #5
a.aaronjake commentedHi @urvashi_vora,
Applied your patch not-so successfully, might be the reason errors are still thrown. Please see below.
Kindly check.
Thanks,
Jake
Comment #9
avpadernoComment #10
atul_ghate commentedComment #12
joseph.olstadComment #13
joseph.olstad