... and not to the user's account.

Comments

omar’s picture

... due to the fact that all sites have "webmaster@localhost" as the email for uid#1

adrian’s picture

Use the signup form to create sites and client nodes in one action

omar’s picture

I'll try that. But this implies that we shouldn't use "create content >> site"?

adrian’s picture

You can. if the client already exists.

create content >> site is more for admin use.

The clients will be able to create sites from themselves using node/$client_id/add/site
new clients can create accounts for themselves using hosting/signup.

anarcat’s picture

I still feel that the contact email for the site should be the user. In fact, it could be considered that the user that created the site for client X is the main contact for the site. The hosting interface should also allow this setting to be changed on the fly and send password reset emails...

For future reference, the code that sets the client_email is in hosting_client.module, in hosting_client_provision_args(). The mail itself is sent from provision_drupal_send_welcome_mail .

markfoodyburton’s picture

anarcat’s picture

Basically, my current stance on this bug is that we shouldn't have an email associated with the client, but with the users. Emails should be sent to some or all users of the client with the login URL.

I am also considering blending OpenID in there since we have a user database that is shared with our openid provider: every aegir user has an openid associated to it that we could just setup in the admin account of the new site. See #462790: enable SSO in deployed sites.

adrian’s picture

Status: Active » Postponed (maintainer needs more info)

sooooo i am pretty close to marking this by design.

antoine: what do you think ?

adrian’s picture

Status: Postponed (maintainer needs more info) » Closed (works as designed)
anarcat’s picture

Title: Confirmation e-mails are sent to the administrator account... » Confirmation e-mails should be sent to client users, not to the client email
Version: 5.x-0.1-beta1 » 6.x-0.4-alpha3
Component: Code » User interface
Assigned: Unassigned » anarcat
Category: bug » feature
Status: Closed (works as designed) » Active

I didn't have time to respond to this until now, but I don't see why we should send the email to the client instead of the user creating the account.

This, paired with #962330: refactor and clarify the fields in the client content type and #461840: type client/user relationships would make things much more orthogonal and sensical: emails would be sent to admin and tech contacts of the account, simply.

While the signup form allows creation of sites and clients in one shot, that doesn't cover all use cases, and especially not the "consulting firm" or "mass hosting" case where one client can have multiple sites and where you want to be able to control who the emails are sent to, for example.

anarcat’s picture

Status: Active » Needs review

Some progress here: I have opened a feature branch in the backend to get the email from the task dynamically. The branch is named dev-noreg-mail-336068

This requires the dev-refactor-client-962330 branch from #962330: refactor and clarify the fields in the client content type.

anarcat’s picture

Project: Hosting » Provision
Version: 6.x-0.4-alpha3 » 6.x-1.0-rc2
anarcat’s picture

And if this doesn't work, i suggest we rip the mail sending code away from the frontend and do the mail stuff in the frontend, as a post task in hosting.

anarcat’s picture

Status: Needs review » Fixed

this actually work and is really simple - i posted a few patches on master.

anarcat’s picture

Status: Fixed » Patch (to be ported)

More precisely, those patches are on hostmaster 'master' branch now and await testing before backporting.:

616053abf7e351d92d64ae5bdf118da76e8f8524
49a5d9f043520ae04e2d6041001babe6e7497ab8

anarcat’s picture

Project: Provision » Hostmaster (Aegir)
Version: 6.x-1.0-rc2 » 6.x-0.4-alpha3
anarcat’s picture

Status: Patch (to be ported) » Fixed

this was merged in stable for the rc3 release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 49a5d9f on dev-refactor-client-962330, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by anarcat:
    #336068 - send confirmation email to the user creating the task instead...
  • Commit dbddad0 on dev-refactor-client-962330, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by anarcat:
    #336068 - load the right user in tasks from the signup form
    
    
  • Commit dd0d008 on dev-refactor-client-962330, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by anarcat:
    #336068 - load the right user in tasks from the signup form
    
    
  • Commit 616053a on dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by anarcat:
    #336068 - load the right user in tasks from the signup form
    
    

  • Commit 49a5d9f on dev-refactor-client-962330, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by anarcat:
    #336068 - send confirmation email to the user creating the task instead...
  • Commit dbddad0 on dev-refactor-client-962330, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by anarcat:
    #336068 - load the right user in tasks from the signup form
    
    
  • Commit dd0d008 on dev-refactor-client-962330, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by anarcat:
    #336068 - load the right user in tasks from the signup form
    
    
  • Commit 616053a on dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by anarcat:
    #336068 - load the right user in tasks from the signup form