Problem/Motivation

Amongst the current suppressions found in the PHPStan level 1 baseline is: Cannot unset offset 'foo' on array<int, string>..

This issue exists to fix all of those.

Steps to reproduce

- Run PHPStan on level 1 and see the above suppression(s) amongst all others.

Proposed resolution

- Remove (all of) the reported suppression(s) for the above mentioned and have no TestBot failures.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3359048

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !3961

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented

Note: I tried adding an @return string[] to \Drupal\Core\DependencyInjection\DependencySerializationTrait::__sleep, also to it's return, but somehow PHPStan doesn't pick up on it.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Applied the MR and searched for "Cannot unset offset" and the 7 instances were removed.

Looks good to me.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed cc97afe40d to 11.x (10.2.x). Thanks!

  • longwave committed cc97afe4 on 11.x 
    Issue #3359048 by Spokje, smustgrave: Fix PHPStan L1 errors "Cannot...

Spokje closed merge request !3961

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.