GitLab CI reports PHP_CodeSniffer errors/warnings which should be fixed.

Issue fork po_translations_report-3358998

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sidharth_soman created an issue. See original summary.

sidharth_soman’s picture

sidharth_soman commented
Status: Active » Needs work

I will work on the issues and provide an MR.

sidharth_soman opened merge request !3

sidharth_soman’s picture

sidharth_soman commented
Assigned: sidharth_soman » Unassigned
Status: Needs work » Needs review

I've fixed all the issues except for those relating to documentation... which should be ideally resolved by the maintainers.

Please review the above MR.

cleavinjosh’s picture

cleavinjosh commented
Status: Needs review » Needs work

Hi @sidharth_soman,

I applied MR!3 and it was applied smoothly. However, I still encountered some issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.

➜  po_translations_report git:(8.x-1.x) curl https://git.drupalcode.org/project/po_translations_report/-/merge_requests/3.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 48019    0 48019    0     0    99k      0 --:--:-- --:--:-- --:--:--   99k
patching file config/install/po_translations_report.admin_config.yml
patching file config/schema/po_translations_report.schema.yml
patching file po_translations_report.info.yml
patching file po_translations_report.links.menu.yml
patching file po_translations_report.module
patching file po_translations_report.services.yml
patching file src/Annotation/PoTranslationsReportDetailsDisplayer.php
patching file src/Annotation/PoTranslationsReportDisplayer.php
patching file src/Controller/PoTranslationsReportController.php
patching file src/DetailsDisplayerPluginBase.php
patching file src/DetailsDisplayerPluginInterface.php
patching file src/DetailsDisplayerPluginManager.php
patching file src/DisplayerPluginBase.php
patching file src/DisplayerPluginInterface.php
patching file src/DisplayerPluginManager.php
patching file src/Form/PoTranslationsReportAdmin.php
patching file src/Plugin/PoTranslationsReportDetailsDisplayer/HtmlTable.php
patching file src/Plugin/PoTranslationsReportDisplayer/SortableLinkedDataTable.php
patching file src/PoDetailsReporter.php
patching file src/PoReporter.php
patching file src/Tests/PoTranslationsReportTest.php
➜  po_translations_report git:(8.x-1.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml po_translations_report

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/po_translations_report/po_translations_report.info.yml
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
---------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/po_translations_report/src/PoReporter.php
----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/po_translations_report/src/Form/PoTranslationsReportAdmin.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------
 25 | ERROR | Missing @var tag in member variable comment
 30 | ERROR | Missing @var tag in member variable comment
----------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/po_translations_report/src/DisplayerPluginInterface.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\ConfigurableInterface.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/po_translations_report/src/Tests/PoTranslationsReportTest.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Extension\ExtensionPathResolver.
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/po_translations_report/src/Plugin/PoTranslationsReportDisplayer/SortableLinkedDataTable.php
----------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------
 19 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/po_translations_report/src/Plugin/PoTranslationsReportDetailsDisplayer/HtmlTable.php
---------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------
 18 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
---------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/po_translations_report/src/Controller/PoTranslationsReportController.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
  7 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Xss.
 18 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
 70 | ERROR   | [ ] Parameter $translationManager is not described in comment
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/po_translations_report/src/DetailsDisplayerPluginInterface.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Plugin\ConfigurableInterface.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/po_translations_report/src/PoDetailsReporter.php
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
 10 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
---------------------------------------------------------------------------------------------------------------------

Time: 473ms; Memory: 12MB

➜  contrib git:(main) ✗

Please check and advise.
Thank you.

hetal.solanki’s picture

hetal.solanki
Primary language English
commented
Assigned: Unassigned » hetal.solanki

Hetal.Solanki changed the visibility of the branch 3358998-dev to hidden.

Hetal.Solanki changed the visibility of the branch 3358998-dev to active.

hetal.solanki’s picture

hetal.solanki
Primary language English
commented
Assigned: hetal.solanki » Unassigned
cleavinjosh’s picture

cleavinjosh commented
Status: Needs work » Needs review

Hi,

I fixed the remaining phpcs issues.

Please review. Thank you.

vinmayiswamy’s picture

vinmayiswamy commented
Status: Needs review » Reviewed & tested by the community

Hi,
I've tested MR !3 on Drupal 10.3.x.

The MR is applied Cleanly...

Test Result:
The phpcs issues were fixed after the updated changes.

RTBC+1

Thanks!

avpaderno changed the visibility of the branch 3358998-dev to hidden.

avpaderno opened merge request !5

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes

avpaderno changed the visibility of the branch 3358998-gitlab-ci-reports to hidden.

izus’s picture

izus commented
Status: Reviewed & tested by the community » Fixed

This is now merged
thanks

izus’s picture

izus commented
Status: Fixed » Closed (fixed)