Problem/Motivation

Amongst the current suppressions found in the PHPStan level 1 baseline is: Class \Foo\Bar not found..

This issue exists to fix all of those.

Steps to reproduce

- Run PHPStan on level 1 and see the above issue amongst all others.

Proposed resolution

- Solve all of the reported issues for the above mentioned.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3358890

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Version: 10.0.x-dev » 10.1.x-dev

Spokje opened merge request !3954

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Applied MR and searched for "\Tasks not found" and both instances have been addressed.

mondrake’s picture

mondrake
Location 🇮🇹
commented

I’m not sure we really intend to test missing classes here - rather I feel like it’s a gap in the stub drivers implementations. Maybe we can get @daffie’s point of view here?

spokje’s picture

spokje
Primary language Dutch
commented

Hmm, maybe my comment is incorrect/not precise enough.

I'm sure we're not testing missing classes, but maybe there were no classes in core's codebase that fit the brief, so it was easier to "make some up" for testing namespace-dependant ordering.

Anyway: I always welcome @daffie's expertise.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Ah, but that’s in a legacy deprecation test, that will go away anyway. So no bother. RTBC++

daffie’s picture

daffie commented

+1 for RTBC.

mondrake’s picture

mondrake
Location 🇮🇹
commented

Added a comment inline. It's a nit.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 95c061fa9c to 11.x (10.2.x). Thanks!

  • longwave committed 95c061fa on 11.x 
    Issue #3358890 by Spokje, mondrake, smustgrave: Fix PHPStan L1 errors "...

Spokje closed merge request !3954

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.