ReadSpeaker blocks are invalidated only based on URL, but when the settings is changed, cached blocks are not invalidated.

CommentFileSizeAuthor
#2 cached_blocks_are_not_invalidated_when_settings_change-3358831-2.patch743 bytesdurifal

Issue fork open_readspeaker-3358831

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

durifal created an issue. See original summary.

durifal’s picture

durifal commented
Assigned: durifal » Unassigned
Status: Active » Needs review
StatusFileSize
new cached_blocks_are_not_invalidated_when_settings_change-3358831-2.patch743 bytes

I have created patch to fix this bug. So when you edit settings, all cached blocks are invalidated.

sunlix’s picture

sunlix
Primary language English
Location Wesel
commented

@durifal

thank you for your contribution. Can you commit your changes to an issue fork and create a merge request?
This approach is more easier for project maintainer to review and at least commit the proposed changes.
thank you for your support.

keshav.k made their first commit to this issue’s fork.

keshav.k opened merge request !22

keshavv’s picture

keshavv commented

Hi @sunlix
I have created the MR of #2 patch please review.

  • sunlix committed 6318b12b on 2.x authored by keshav.k 
    Issue #3358831 by keshav.k, durifal, sunlix: Cached blocks are not...
sunlix’s picture

sunlix
Primary language English
Location Wesel
commented
Status: Needs review » Fixed

Thank you, I've remove another unused Cache invalidate.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.