The test bot once again reports a few coding standards violation – apparently, deprecation messages in trigger_error() shouldn’t contain a period after the URL (which makes sense).
One baffling thing, though, is that the test bot’s ESLint report states that the $ in line 6 of js/search_api.processors.js should be wrapped in parentheses, while my local ESLint reports complains when I do that. So, I will leave that as-is for now (to not be irritated during local development), but would very much like to know the explanation, and make my local results consistent with the test bot.

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

Status: Active » Needs review
StatusFileSize
new5.67 KB

This also removes a few outdates comments.

drunken monkey’s picture

Issue summary: View changes

drunken monkey’s picture

StatusFileSize
new429 bytes
new6.09 KB

Thanks to @tobiasb, I was able to reproduce the results from the test bot, so here is a patch also including the JS fix.

  • drunken monkey committed bbbc1f37 on 8.x-1.x
    Issue #3358661 by drunken monkey, tobiasb: Fixed coding standards.
    
drunken monkey’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.