Deprecate \Drupal\Tests\RandomGeneratorTrait::randomStringValidate [#3358384]

Problem/Motivation

Maybe [we can deprecate] RandomGeneratorTrait::randomStringValidate() which is just a callback that is no longer called since the entire implementation moved to the new static methods.

@mondrake in #3358186-5: [META] Deprecate non-static random generation methods from RandomGeneratorTrait

Steps to reproduce

Proposed resolution

Deprecated in drupal:10.2.0 and is removed from drupal:11.0.0.
Use \Drupal\TestTools\Random::stringValidate() instead.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3358384

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1 hidden branch

3358384-deprecate-drupaltestsrandomgeneratortraitrandomstringvalidate

changes, plain diff MR !3937

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

5 May 2023 at 07:54

Spokje created an issue. See original summary.

Comment #2

spokje

Dutch

commented 5 May 2023 at 07:58

Title:	Deprecate \Drupal\Tests\RandomGeneratorTrait::randomStringValidate	» [PP-1] Deprecate \Drupal\Tests\RandomGeneratorTrait::randomStringValidate
Status:	Active	» Postponed

Postponing on #3358375: Fix incorrect usage of randomStringValidate in \Drupal\Tests\jsonapi\Kernel\Normalizer\JsonApiDocumentTopLevelNormalizerTest::setUp

Comment #3

spokje

Dutch

commented 5 May 2023 at 08:05

Assigned:

Unassigned

» spokje

Comment #4

spokje

Dutch

commented 5 May 2023 at 08:06

Issue summary:

View changes

Comment #5

spokje

Dutch

commented 5 May 2023 at 08:07

Issue summary:

View changes

Comment #6

5 May 2023 at 08:07

Spokje opened merge request !3937

Comment #7

5 May 2023 at 08:07

Version:

10.1.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #8

mondrake

🇮🇹

commented 3 July 2023 at 20:12

Title:	[PP-1] Deprecate \Drupal\Tests\RandomGeneratorTrait::randomStringValidate	» Deprecate \Drupal\Tests\RandomGeneratorTrait::randomStringValidate
Status:	Postponed	» Needs work

Blocker’s in now.

Comment #9

spokje

Dutch

commented 4 July 2023 at 06:06

Issue summary:

View changes

Rebased MR on 11.x, changed deprecation message in IS, MR and CR.

Comment #10

spokje

Dutch

commented 4 July 2023 at 06:45

Status:

Needs work

» Reviewed & tested by the community

Thanks for the headsup @mondrake.

Comment #11

spokje

Dutch

commented 4 July 2023 at 06:49

Assigned:

spokje

» Unassigned

Comment #12

spokje

Dutch

commented 4 July 2023 at 06:58

Status:

Reviewed & tested by the community

» Needs review

Whoops, thoght this was already RTBC at some point...

Comment #13

mondrake

🇮🇹

commented 4 July 2023 at 10:16

Status:

Needs review

» Needs work

I suppose we need a deprecation test here...

Comment #14

spokje

Dutch

commented 4 July 2023 at 10:33

Status:

Needs work

» Needs review

Also thought so, but appearantly, that ran out of fashion on Traits?

No deprecation tests that I could find on, for example:

- this \Drupal\views\Entity\Render\EntityTranslationRenderTrait::getEntityTranslation
- this \Drupal\Tests\book\Functional\BookTestTrait::generateOutlinePattern

So, unless my search failed, I'm not bothering with that ATM.

Comment #15

mondrake

🇮🇹

commented 4 July 2023 at 10:54

Status:

Needs review

» Reviewed & tested by the community

Let's see feedback from committers then.

Comment #16

spokje

Dutch

commented 4 July 2023 at 11:14

* runs to the popcorn store *

Comment #17

10 July 2023 at 15:59

catch committed cfb55ae2 on 10.1.x

Issue #3358384 by Spokje, mondrake: Deprecate \Drupal\Tests\...

Comment #18

10 July 2023 at 15:59

catch committed 4df80c61 on 11.x

Issue #3358384 by Spokje, mondrake: Deprecate \Drupal\Tests\...

Comment #19

10 July 2023 at 15:59

catch committed 5c295724 on 10.1.x

Revert "Issue #3358384 by Spokje, mondrake: Deprecate \Drupal\Tests\...

Comment #20

catch

he/him

English

commented 10 July 2023 at 16:00

Status:

Reviewed & tested by the community

» Fixed

Yes if the deprecation test would only test that we call trigger_error() with correct string, then it's fine not to bother with a deprecation test. If there's actual bc logic (outside trivial stuff in a constructor) it's a bit different.

Committed 4df80c6 and pushed to 11.x. Thanks!