Problem/Motivation

The recent poll block is not providing a contextual link to edit the poll.

Steps to reproduce

Add the block to any page, check the contextual links available.

Proposed resolution

Add a contextual link called "Edit Poll".

Issue fork poll-3357205

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jidrone created an issue. See original summary.

jidrone opened merge request !18

jidrone’s picture

jidrone commented
Status: Active » Needs review

Created MR and moved to Needs Review.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Added a few nit comments :)

schlaukopf’s picture

schlaukopf commented

I tested the patch and it works, but I agreed with @bramdriesen on poll_edit, but maybe something like the core does like entity.poll.edit_form

jidrone’s picture

jidrone commented

Really good findings, I just fixed them, so it should be ready to review again.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Code looks good! Given @schlaukopf tested it think we can RTBC this. Not sure if the maintaner wants a test for this.

ivnish’s picture

ivnish
he/him
commented

Up!

  • BramDriesen committed 9d4c471a on 8.x-1.x authored by jidrone 
    Issue #3357205 by jidrone, BramDriesen, schlaukopf: Provide contextual...

  • BramDriesen committed 62e72309 on 2.0.x 
    Issue #3357205 by jidrone, BramDriesen, schlaukopf: Provide contextual...
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Version: 8.x-1.x-dev » 2.0.x-dev
Status: Reviewed & tested by the community » Fixed
Issue tags: +MountainCamp2024

Merged and also committed to 2.0.x. Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.