Problem/Motivation

  • Update dictionary of translation words used in SPA forms.
  • Update SPA build script to automatically generate .ts files for SPA from .po files for Drupal

Issue fork cloud-3357000

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1763

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. We need to address the following multiple lines of msgstr like:

msgstr ""
"[Unused column] "
"クラウドサービスプロバイダ用のユニークな ID"
ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I fixed data conversion even when msgid spans multiple lines. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

I think it is not still enough to convert e.g.:

https://git.drupalcode.org/project/cloud/-/blob/847024e9ceb4512a0e430640...

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue tags: +chatgpt
ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Can we remove Drupal.t("");? 

$ cat src/constant/translations/translation.ts 
Drupal.t("");
Drupal.t("tags");
Drupal.t("Body");
Drupal.t("Images");

I think we should skip the following item:

msgid ""
msgstr ""

Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. I could confirm the patch worked. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 05202c6b on 6.x authored by Ryo Yamashita 
    Issue #3357000 by Ryo Yamashita, yas: Update dictionary of translation...

  • yas committed 2dc021e6 on 5.x authored by Ryo Yamashita 
    Issue #3357000 by Ryo Yamashita, yas: Update dictionary of translation...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.