This is a follow-up to #3206643: Project messaging channel in core (as experimental) to give users a way to access the announcements feed if the toolbar module is disabled.
The feed is accessible via the "/admin/announcements_feed" route, but that link is not displayed anywhere if the toolbar module is disabled.
Show the link in the following situations:
* The help text provided by the module.
* New link under the "/admin" route.
Provide MR.
New "Annoucements" link will appear when viewing the help page and also when going under "/admin".
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | Screenshot 2023-05-02 at 10.40.28 PM.png | 771.24 KB | varun verma |
| #5 | Screenshot 2023-04-28 at 10.57.26.png | 112.41 KB | fjgarlin |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !3888
Comments
Comment #2
fjgarlin commentedComment #3
fjgarlin commentedComment #5
fjgarlin commentedReady to review.
Enable the module, then navigate to "/admin", and you should see something like this if you have toolbar enabled:
If the toolbar module is disabled, you can still see the link and access notifications.
If you navigate to the "/admin/help" page, and then click on "Announcements" (/admin/help/announcements_feed), you will also see a link to the announcements page.
Comment #6
smustgrave commentedWonder if the IS could be updated if a solution.
Tried testing the patch and if the solution to add a link to the Structure page I did not see the link. Cleared cache several times
And when toolbar module is enabled I'm not seeing Announcements twice in the toolbar. Think that could be confusing.
Comment #7
fjgarlin commentedComment #8
fjgarlin commentedI updated the IS with the solution that this MR provides.
It was never under the "Structure" page, it was, and it still is, under the "/admin" page. I tried to think about arguments to add it inside the "Content", "Structure" or "Configuration" menu, but this is none of those really, so a link under the "Administration" page seems appropriate.
That has been addressed now. It's shown only once.
--
With this MR, the help text provides a link to access the announcements page directly and it also shows a link under the "/admin" and "/admin/index" pages to access the announcements.
Comment #9
varun verma commentedI have review that, when toolbar module is enabled then Announcements showing once only. screenshot attached for reference.
Comment #10
smustgrave commentedThanks for the issue summary update.
Tested again when the toolbar module is disabled the link does appear under
/admin technically it appears with or without the toolbar module I should say.
Comment #14
longwaveDiscussed with @lauriii and @catch, given that this makes the new module more usable without toolbar being installed we agreed to backport to 10.1.x.
Committed and pushed 8b92bea8c7 to 11.x (10.2.x) and 611cda6107 to 10.1.x. Thanks!