Problem/Motivation

Change to use cloud_dashboard's SPA as the default UI.

CommentFileSizeAuthor
#4 Additional_configurations___Cloud_Orchestrator_🔊.png221.21 KBbaldwinlouie

Issue fork cloud_orchestrator-3356082

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie opened merge request !57

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review

@yas please review this patch. This adds the SPA on/off checkbox during Cloud Orchestrator installation. This patch also refactors certain service calls to use dependency injection.

baldwinlouie’s picture

baldwinlouie commented
StatusFileSize
new Additional_configurations___Cloud_Orchestrator_🔊.png221.21 KB

Here is what the fields look like during installation.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@baldwinlouie

Thank you for the patch. I posted my comment. Thanks

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review

@yas, please review this. I solved the refactoring using another method.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Use cloud_dashboard's SPA as the default UI. » Support drupal/cloud_dashboard's SPA as the default UI
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for the update. I like your idea. I'll merge the patch to 6.x, and close this issue as Fixed.

  • yas committed 4f65e044 on 6.x authored by baldwinlouie 
    Issue #3356082 by baldwinlouie, yas: Support drupal/cloud_dashboard's...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.