Problem/Motivation

@mglaman released version 1.1.30 of mglaman/phpstan-drupal (See https://github.com/mglaman/phpstan-drupal/releases/tag/1.1.30)
Looking at https://www.drupal.org/node/3060/qa it removes some false positives on Level 1.

Steps to reproduce

See https://www.drupal.org/node/3060/qa and notice the failures on both updated deps jobs for 10.0.x and 10.1.x

Proposed resolution

- Upgrade mglaman/phpstan-drupal
- Create a new baseline
- Bump version of mglaman/phpstan-drupal in composer.json to 1.1.30, since the newly created baseline won't pass on any version below that.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3355137-10.0.x-6.patch17.04 KBspokje
#3 3355137-3.patch17.04 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3355137-3.patch17.04 KB
spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Active » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

10.1.x looks OK, 10.0.x patch doesn't apply.

spokje’s picture

spokje
Primary language Dutch
commented
Version: 10.1.x-dev » 10.0.x-dev
Status: Needs work » Needs review
StatusFileSize
new 3355137-10.0.x-6.patch17.04 KB
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

LGTM.

spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3330981: Fix PHPStan L1 error "Relying on entity queries to check access by default is deprecated..."

  • catch committed 46353b6b on 10.0.x 
    Issue #3355137 by Spokje: Update mglaman/phpstan-drupal and make daily "...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed the respective patches to 10.1.x and 10.0.x, thanks!

  • catch committed 9a1b7644 on 10.1.x 
    Issue #3355137 by Spokje: Update mglaman/phpstan-drupal and make daily "...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.