Getting following errors.
FILE: /var/www/html/modules/contrib/taxonomy_depth_widget/src/Plugin/Field/FieldWidget/TermOptionsButtonsWidget.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
118 | ERROR | The array declaration extends to column 87 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/modules/contrib/taxonomy_depth_widget/src/Plugin/Field/FieldWidget/TermOptionsSelectWidget.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
121 | ERROR | The array declaration extends to column 87 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------
Time: 942ms; Memory: 6MB
Run following command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/taxonomy_depth_widget/
Above errors need to be fixed.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3355066-after.png | 29.18 KB | ashutosh ahirwal |
| #5 | 3355066-before.png | 102.54 KB | ashutosh ahirwal |
| #3 | 3355066-After-Patch.png | 46.69 KB | clarkssquared |
| #3 | 3355066-Before-Patch.png | 88.34 KB | clarkssquared |
| #2 | 3355066-2.patch | 1.25 KB | samitk |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #2
samitk commentedIssue fixed.
Comment #3
clarkssquared commentedHi samit.310@gmail.com
I applied your patch #2 to the "Taxonomy Depth Widget" module against version 2.1.0. and confirmed that the mentioned phpcs errors were fixed, however, another new phpcs error was being flagged relating to taxonomy_depth_widget.info.yml.
Please look at the screenshot for your reference,
Thank you.
Comment #5
ashutosh ahirwal commentedHi @samit.310@gmail.com i have retested your patch with cloning the module from git clone command available on version control tab and it looks fine to me.
@clarkssquared I guess you have tested the patch after using the composer command to clone/download the module by using the composer command the "version, project, datestamp" get added by drupal in module info file.
Moving to RTBC.
Comment #7
fabiansierra5191 commentedFixed on version 2.1.1, thanks for the patch and the tests!
Comment #8
fabiansierra5191 commented