Problem/Motivation

FILE: ...ahubbers/Sites/drupal-voor-gemeenten/projects/dvgemdemo/htdocs/modules/contrib/bsn_field/tests/src/Kernel/BSNItemTest.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 17 | ERROR | Class name doesn't match filename; expected "class BSNItemTest"
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/joshahubbers/Sites/drupal-voor-gemeenten/projects/dvgemdemo/htdocs/modules/contrib/bsn_field/README.md
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 25 | WARNING | Line exceeds 80 characters; contains 81 characters
-------------------------------------------------------------------------------------------------------------------

FILE: /Users/joshahubbers/Sites/modules/bsn_field/bsn_field.module
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 45 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "_bsn_elfproef" but
    |       | expected "bsn_field__bsn_elfproef"
-------------------------------------------------------------------------------------------------------------------------------
CommentFileSizeAuthor
#7 3354285-after-patch.png866.2 KBclarkssquared
#5 phpcs_fixes-3354285.patch1.7 KBchetan 11

Issue fork bsn_field-3354285

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

JoshaHubbers created an issue. See original summary.

joshahubbers’s picture

joshahubbers commented
Issue summary: View changes
joshahubbers’s picture

joshahubbers commented
Issue summary: View changes

JoshaHubbers opened merge request !1

chetan 11’s picture

chetan 11 commented
StatusFileSize
new phpcs_fixes-3354285.patch1.7 KB

@JoshaHubbers
I have fixed the phpcs. Please review it.

chetan 11’s picture

chetan 11 commented
Status: Active » Needs review
clarkssquared’s picture

clarkssquared commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3354285-after-patch.png866.2 KB

hi chetan 11,

I applied your patch #5 and I confirmed that it fixes all the PHPCS issues.

Please look at the screenshot I attached,

Thank you

joshahubbers’s picture

joshahubbers commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.