Problem/Motivation

  • Clean up legacy configurations to support Drupal 10.x

Issue fork cloud_orchestrator-3354112

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

baldwinlouie created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Remove legacy configurations to support Drupal 10.x » Drupal 10 compatibility: Remove legacy configurations to support Drupal 10.x
Issue summary: View changes
Issue tags: +Drupal 10 compatibility, +Drupal 10 compatibility fixes

baldwinlouie opened merge request !55

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review

@yas please review the patch. This will get Cloud Orchestrator installed when using Drupal 10. I've fixed the following

1. Removed orphaned permissions. In Drupal 10, orphaned permissions will throw an execption.
2. Removed unused configurations.
3. Since all Cloud Service Providers are enabled in `cloud_orchestrator.info.yml`, I removed the optional checkboxes asking the user to enable them. It is redundant.
4. Fixed the tour styling.
5. Fixed the `core_requirements` in `cloud_orchestrator_tour.info.yml`

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Drupal 10 compatibility: Remove legacy configurations to support Drupal 10.x » Drupal 10 compatibility: Remove legacy configurations to support drupal/core:^10

@baldwinlouie

Thank you for the patch. The patch quality looks good. I'll merge the patch to 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

  • yas committed 6f8d71c9 on 6.x authored by baldwinlouie 
    Issue #3354112 by baldwinlouie, yas: Remove legacy configurations to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3353144: [META] Drupal 10 compatibility: Module Compatibility Drupal 9 to 10

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.