Expected 1 new line at the end of file [#3353686]

Problem/Motivation

As per Drupal and DrupalPractice coding standards, expected 1 new line at the end of file.

FILE: ...ntrib/personal_views_access_control/personal_views_access_control.info.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
8 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...b/personal_views_access_control/personal_views_access_control.services.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
11 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...l_views_access_control_test/personal_views_access_control_test.routing.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
155 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...onal_views_access_control_test/personal_views_access_control_test.info.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
10 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...ccess_control/config/schema/personal_views_access_control.views.schema.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
28 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 1.09 secs; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig personal_views_access_contro

Proposed resolution

Add a new line at the end of respective files.

Remaining tasks

Apply patch and review the patch.

Comment	File	Size	Author
	one-new-line.patch	2.62 KB	urvashi_vora

Issue fork personal_views_access_control-3353686

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3353686-expected-1-new-line changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

12 April 2023 at 10:48

urvashi_vora created an issue. See original summary.

Comment #2

jyraya commented 18 April 2023 at 20:50

Assigned:

Unassigned

» jyraya

Hi @urvashi_vora,

Thanks for reporting the issue!
I will review the patch this week, as soon as I have access to my dev environment.

Regards.

Comment #3

26 April 2023 at 21:18

jyraya opened merge request !1

Comment #4

26 April 2023 at 21:26

jyraya committed bb4e792a on 1.0.x

Issue #3353686: Expected 1 new line at the end of file

Comment #5

jyraya commented 26 April 2023 at 21:27

Status:

Needs review

» Fixed

I finally reviewed the patch and merge it.

Thanks for the contribution!

Comment #6

10 May 2023 at 21:29

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Expected 1 new line at the end of file