Problem/Motivation

Fix the issues reported by PHPCS for Drupal and DrupalPractice coding standards.

FILE: .../web/modules/contrib/ckeditor5_findandreplace/js/build/find-and-replace.js
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------

FILE: ...b/modules/contrib/ckeditor5_findandreplace/ckeditor5_findandreplace.module
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] Expected 1 newline at end of file; 2 found
1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...ntribution/drupal10/web/modules/contrib/ckeditor5_findandreplace/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 158 characters
--------------------------------------------------------------------------------

FILE: ...es/contrib/ckeditor5_findandreplace/ckeditor5_findandreplace.ckeditor5.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
12 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 268ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig ckeditor5_findandreplace/

Proposed resolution

Fix all issues in respective files as per the report

Remaining tasks

Patch review

CommentFileSizeAuthor
coding-standards.patch94.86 KBurvashi_vora

Comments

urvashi_vora created an issue. See original summary.

tanuj.’s picture

tanuj. commented
Status: Needs review » Needs work

Verified and tested the patch and it fixes all the coding standard issues, although idk if we need fix for .js file it seems redundant to me and makes the patch quite big in size, so changing the status to needs work. if you think .js file fix is important feel free to change the status to RTBC
Thanks. 

FILE: .../web/modules/contrib/ckeditor5_findandreplace/js/build/find-and-replace.js
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------
sujan shrestha’s picture

sujan shrestha commented
Version: 1.1.1 » 1.1.2
Assigned: Unassigned » sujan shrestha
Status: Needs work » Fixed
sujan shrestha’s picture

sujan shrestha commented
Status: Fixed » Closed (fixed)