Problem/Motivation

  • Add location ((latitude / longitude, zoom level) settings to dashboard config form

Issue fork cloud-3353595

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !1717

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add location settings to dashboard config form » Add location settings to dashboard admin form
Issue summary: View changes
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the patch. It looks good. Can you fix the following coding standard error?

FILE: .../cloud_dashboard/src/Form/Config/CloudDashboardAdminSettings.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 199 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait
     |         | and $this->t() instead
----------------------------------------------------------------------

Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Thanks for your comment. I fixed the code. Please take a look again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add location settings to dashboard admin form » Add location fields to Cloud dashboard admin settings form
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. It looks good. I'll merge the patch to 4.x, 5.x and 6.x, and close this issue as Fixed.

  • yas committed fcb3500f on 6.x authored by Xiaohua Guan 
    Issue #3353595 by Xiaohua Guan, yas: Add location fields to Cloud...

  • yas committed 7aa12071 on 5.x authored by Xiaohua Guan 
    Issue #3353595 by Xiaohua Guan, yas: Add location fields to Cloud...

  • yas committed ff675d9c on 4.x authored by Xiaohua Guan 
    Issue #3353595 by Xiaohua Guan, yas: Add location fields to Cloud...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.