Problem/Motivation

In #3350972: [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections() @nod_ introduced a "fix" for problems with the correct opening of an off-canvas dialog which potentially could fix all JS random test failures for tests using the drupal.dialog.off_canvas somehow.

The basic test is:

  1. Unskip \Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderTest::testLayoutBuilderUi.
  2. Run _only_ now unskipped \Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderTest::testLayoutBuilderUi a lot of times (usually we go for 1500x) as-is.
  3. Run _only_ now unskipped \Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderTest::testLayoutBuilderUi a lot of times (usually we go for 1500x) _without_ the changes in #3350972: [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections().
  4. If 2., passes and 3. doesn't, we can safely turn the test back on again.

Per @xjm in #3353085-4: [meta] Determine impact of [#3350972] fix in off-canvas.js on currently disabled FunctionalJavascript tests we now need to go for a 5000-8000 times run for both patches.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#4 3353179-4.patch623 bytesspokje
#2 LayoutBuilderTest_testLayoutBuilderUi-no_#3350972-1500x-should_fail.patch8.28 KBspokje
#2 LayoutBuilderTest_testLayoutBuilderUi-1500x.patch7.79 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new LayoutBuilderTest_testLayoutBuilderUi-1500x.patch7.79 KB
new LayoutBuilderTest_testLayoutBuilderUi-no_#3350972-1500x-should_fail.patch8.28 KB
spokje’s picture

spokje
Primary language Dutch
commented

Both should_fail and non_fail patch run 5 times. That's 7500 individual tests per patch.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new 3353179-4.patch623 bytes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented

Both should_fail and non_fail patch ran 5 times. That's 7500 individual tests per patch.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Conditions of the issue summary appear to have been met. Know we are staggering these in 12 hours apart so adding to the list to be added.

  • catch committed da340507 on 10.1.x 
    Issue #3353179 by Spokje: [random test failure] Try to un-skip and fix...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Patch (to be ported)

Committed da34050 and pushed to 10.1.x. Thanks!

Leaving 'to be ported' for 10.0.x and lower.

  • catch committed b14073a0 on 10.0.x 
    Issue #3353179 by Spokje: [random test failure] Try to un-skip and fix...

  • catch committed a49a2488 on 9.5.x 
    Issue #3353179 by Spokje: [random test failure] Try to un-skip and fix...
catch’s picture

catch
he/him
Primary language English
commented
Version: 10.1.x-dev » 9.5.x-dev
Status: Patch (to be ported) » Fixed

Cherry-picked to 10.0.x and 9.5.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.