Problem/Motivation

In #3350972: [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections() @nod_ introduced a "fix" for problems with the correct opening of an off-canvas dialog which potentially could fix all JS random test failures for tests using the drupal.dialog.off_canvas somehow.

The basic test is:

  1. Unskip \Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderNestedFormUiTest::testAddingFormBlocksToDefaults.
  2. Run _only_ now unskipped \Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderNestedFormUiTest::testAddingFormBlocksToDefaults a lot of times (usually we go for 1500x) as-is.
  3. Run _only_ now unskipped \Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderNestedFormUiTest::testAddingFormBlocksToDefaults a lot of times (usually we go for 1500x) _without_ the changes in #3350972: [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections().
  4. If 2., passes and 3. doesn't, we can safely turn the test back on again.

Per @xjm in #3353085-4: [meta] Determine impact of [#3350972] fix in off-canvas.js on currently disabled FunctionalJavascript tests we now need to go for a 5000-8000 times run for both patches.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3353153-3.patch775 bytesspokje
#2 LayoutBuilderNestedFormUiTest_testAddingFormBlocksToDefaults-no_#3350972-1500x-should_fail.patch4.06 KBspokje
#2 LayoutBuilderNestedFormUiTest_testAddingFormBlocksToDefaults-1500x.patch3.56 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new LayoutBuilderNestedFormUiTest_testAddingFormBlocksToDefaults-1500x.patch3.56 KB
new LayoutBuilderNestedFormUiTest_testAddingFormBlocksToDefaults-no_#3350972-1500x-should_fail.patch4.06 KB
spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new 3353153-3.patch775 bytes
spokje’s picture

spokje
Primary language Dutch
commented
Title: [random test failure] Try to un-skip and fixLayoutBuilderNestedFormUiTest::testAddingFormBlocksToDefaults in context of [#3353085] » [random test failure] Try to un-skip and fix LayoutBuilderNestedFormUiTest::testAddingFormBlocksToDefaults in context of [#3353085]
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

The last submitted patch, 2: LayoutBuilderNestedFormUiTest_testAddingFormBlocksToDefaults-no_#3350972-1500x-should_fail.patch, failed testing. View results

The last submitted patch, 2: LayoutBuilderNestedFormUiTest_testAddingFormBlocksToDefaults-no_#3350972-1500x-should_fail.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: Unassigned » spokje
Status: Needs review » Needs work
spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review

Both should_fail and non_fail patch ran 5 times. That's 7500 individual tests per patch.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Condition of issue summary appears to have been met.

  • catch committed f0723652 on 10.1.x 
    Issue #3353153 by Spokje: [random test failure] Try to un-skip and fix...
catch’s picture

catch
he/him
Primary language English
commented
Version: 10.1.x-dev » 10.0.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to 10.1.x thanks!

Needs cherry-picking once all the related issues are in.

  • catch committed b70464a2 on 10.0.x 
    Issue #3353153 by Spokje: [random test failure] Try to un-skip and fix...

  • catch committed 3efc0cfa on 9.5.x 
    Issue #3353153 by Spokje: [random test failure] Try to un-skip and fix...
catch’s picture

catch
he/him
Primary language English
commented
Version: 10.0.x-dev » 9.5.x-dev
Status: Patch (to be ported) » Fixed

Cherry-picked to 10.0.x and 9.5.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.