Problem/Motivation

In #3350972: [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections() @nod_ introduced a "fix" for problems with the correct opening of an off-canvas dialog which potentially could fix all JS random test failures for tests using the drupal.dialog.off_canvas somehow.

The basic test is:

  1. Unskip \Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderDisableInteractionsTest::assertContextualLinksClickable.
  2. Run _only_ now unskipped \\Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderDisableInteractionsTest::assertContextualLinksClickable a lot of times (usually we go for 1500x) as-is.
  3. Run _only_ now unskipped \Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderDisableInteractionsTest::assertContextualLinksClickable a lot of times (usually we go for 1500x) _without_ the changes in #3350972: [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections().
  4. If 2., passes and 3. doesn't, we can safely turn the test back on again.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 LayoutBuilderDisableInteractionsTest_assertContextualLinksClickable-500x.patch2.79 KBspokje
#6 LayoutBuilderDisableInteractionsTest_assertContextualLinksClickable-no_#3350972-500x-should_fail.patch3.28 KBspokje
#4 LayoutBuilderDisableInteractionsTest_assertContextualLinksClickable-1000x.patch2.79 KBspokje
#4 LayoutBuilderDisableInteractionsTest_assertContextualLinksClickable-no_#3350972-1000x-should_fail.patch3.28 KBspokje
#3 3353103-3.patch1 KBspokje
#2 LayoutBuilderDisableInteractionsTest_assertContextualLinksClickable-no_#3350972-1500x-should_fail.patch3.28 KBspokje
#2 LayoutBuilderDisableInteractionsTest_assertContextualLinksClickable-1500x.patch2.79 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new LayoutBuilderDisableInteractionsTest_assertContextualLinksClickable-1500x.patch2.79 KB
new LayoutBuilderDisableInteractionsTest_assertContextualLinksClickable-no_#3350972-1500x-should_fail.patch3.28 KB
spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new 3353103-3.patch1 KB
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new LayoutBuilderDisableInteractionsTest_assertContextualLinksClickable-no_#3350972-1000x-should_fail.patch3.28 KB
new LayoutBuilderDisableInteractionsTest_assertContextualLinksClickable-1000x.patch2.79 KB

Test seems too slow for 1500x, let's try 1000x.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Active
spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new LayoutBuilderDisableInteractionsTest_assertContextualLinksClickable-no_#3350972-500x-should_fail.patch3.28 KB
new LayoutBuilderDisableInteractionsTest_assertContextualLinksClickable-500x.patch2.79 KB

Still far to slow, let's go 500x

spokje’s picture

spokje
Primary language Dutch
commented
Title: [random test failure] Try to un-skip and fix LayoutBuilderDisableInteractionsTest::assertContextualLinksClickable in context of [#3353085] » [no random test failure] Try to un-skip and fix LayoutBuilderDisableInteractionsTest::assertContextualLinksClickable in context of [#3353085]
Status: Active » Needs review

So basically \Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderDisableInteractionsTest::assertContextualLinksClickable is currently completely broken on Drupal CI.

Locally the should_fail test passes, which indeed points to a timing issue, solved by #3350972: [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections().

spokje’s picture

spokje
Primary language Dutch
commented

Both patches in #6 need to be requeue-ed multiple times until they have both run between 5000-8000 times before this can be reviewed. (See @xjm in #3353085-4: [meta] Determine impact of [#3350972] fix in off-canvas.js on currently disabled FunctionalJavascript tests)

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Needs work
spokje’s picture

spokje
Primary language Dutch
commented

To be clear: I won't be re-queueing patches on this one, so feel free to step in and re-queue away

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review

I queued the jobs. Not sure what the issue is; all you have to do is check "Custom parameters", click queue, hit the back button, and repeat.

spokje’s picture

spokje
Primary language Dutch
commented

all you have to do is check "Custom parameters", click queue, hit the back button, and repeat.

TIL... Never used nor imagined that Custom runs _can_ be queued in advance where the "normal" ones can't.

xjm’s picture

xjm
she/her
Primary language English
commented

Fixing attribution.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Based on the green and red I think the condition of the issue summary has been met haha.

catch’s picture

catch
he/him
Primary language English
commented
Version: 10.1.x-dev » 10.0.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed 40668cf and pushed to 10.1.x. Thanks!

Can be cherry-picked once the others are happily landed in 10.1.x

  • catch committed c2fe4bcb on 10.1.x 
    Issue #3353103 by Spokje: [no random test failure] Try to un-skip and...

  • catch committed e6886d1e on 10.0.x 
    Issue #3353103 by Spokje: [no random test failure] Try to un-skip and...

  • catch committed df41b450 on 9.5.x 
    Issue #3353103 by Spokje: [no random test failure] Try to un-skip and...
catch’s picture

catch
he/him
Primary language English
commented
Version: 10.0.x-dev » 9.5.x-dev
Status: Patch (to be ported) » Fixed

Cherry-picked to 10.0.x, and 9.5.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.