Add a "Location map" fieldset to Cloud dashboard admin settings form

ryo-yamashita

Thank you for the patch. I posted my minor comments. Thanks!

@ryo-yamashita

Can you replace the following screen?

BEFORE:

AFTER:

Here are my thoughs:

• If a user leaves - None - in the Country dropdown box, the selection can be recognized as World map.
• Also, we need to consider the default value when a user leaves - Select - in the Zoom rate dropdown box w/ an validation and error handling.
• You can learn about how it works by checking the existing modules such as cloud, cloud_cluster, k8s, openstack and vmware.

Thanks

@ryo-yamashita

Thank you for the update. Can you fix the coding standard error?
→ https://www.drupal.org/pift-ci-job/2640489

Also, please check my comment in the GitLab code review.

Thanks

@ryo-yamashita

cloud_geocoder JavaScript library automatically handles to get the lat / lon when we specify the country and city so that I don't think we need to introduce a new function like findPosition(). See the following code:

• https://git.drupalcode.org/project/cloud/-/blob/6.x/cloud.module#L157-169
• https://git.drupalcode.org/project/cloud/-/blob/6.x/modules/cloud_cluste...

HTH

@ryo-yamashita

Thank you for the update. Please check my comment at GitLab and fix the following coding standard error:

FILE: .../cloud_dashboard/src/Form/Config/CloudDashboardAdminSettings.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 109 | WARNING | Unused variable $country_options.
----------------------------------------------------------------------

@ryo-yamashita

Please fix the white space at the end of line, too → https://git.drupalcode.org/project/cloud/-/merge_requests/1690#note_165763

@ryo-yamashita

Also, please rebase the patch. The git command gives us the following error while applying the patch:

$ git apply -v /tmp/1690.diff
/tmp/1690.diff:55: trailing whitespace.
 * and zoom factor of the location map. 
Checking patch modules/cloud_dashboard/cloud_dashboard.info.yml...
Checking patch modules/cloud_dashboard/cloud_dashboard.routing.yml...
Checking patch modules/cloud_dashboard/cloud_dashboard/src/organisms/CloudServiceProviderMap.tsx...
Checking patch modules/cloud_dashboard/src/Controller/CloudDashboardConfigController.php...
Checking patch modules/cloud_dashboard/src/Form/Config/CloudDashboardAdminSettings.php...
error: while searching for:

namespace Drupal\cloud_dashboard\Form\Config;

use Drupal\Core\Form\ConfigFormBase;
use Drupal\Core\Form\FormStateInterface;

/**
 * Class Cloud Admin Settings.
 */
class CloudDashboardAdminSettings extends ConfigFormBase {

  /**
   * {@inheritdoc}
   */

error: patch failed: modules/cloud_dashboard/src/Form/Config/CloudDashboardAdminSettings.php:2
error: modules/cloud_dashboard/src/Form/Config/CloudDashboardAdminSettings.php: patch does not apply

@ryo-yamashita

Thank you for the update. Now it is mergeable. Please tail the white space at https://git.drupalcode.org/project/cloud/-/merge_requests/1690#note_165763

diff.patch:55: trailing whitespace.
 * and zoom factor of the location map. 
...
modules/cloud_dashboard/src/Form/Config/CloudDashboardAdminSettings.php cleanly.
warning: 1 line adds whitespace errors.

Thanks

@ryo-yamashita

Thank you for the update. It tested the patch and it looks good. I'll merge the patch to 4.x, 5.x and 6.x, and close this issue as Fixed.