Problem/Motivation

This has started failing randomly but very frequently. Let's skip it then re-enable after fixing.

Steps to reproduce

https://www.drupal.org/pift-ci-job/2628256

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3351494.patch719 bytescatch

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3351494.patch719 bytes
spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3267247: [meta] Fix and re-enable tests skipped for random failures

Sad but true: This is needed at the moment.

Code change only skips MediaSourceFileTest::testMediaFileSource(), so good to go for me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: 3351494.patch, failed testing. View results

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

Random JS failure (oh, the irony!....) which will be handled/skipped in #3351500: Skip Drupal\Tests\layout_builder\FunctionalJavascript\ContextualLinksTest, back to RTBC.

catch’s picture

catch
he/him
Primary language English
commented

Opened #3351516: [random test failure] Drupal\Tests\media\FunctionalJavascript\MediaSourceFileTest.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 4081f86c81 to 10.1.x and a8102e2b67 to 10.0.x. Thanks!

  • longwave committed a8102e2b on 10.0.x 
    Issue #3351494 by catch, Spokje: Skip  Drupal\Tests\media\...

  • longwave committed 4081f86c on 10.1.x 
    Issue #3351494 by catch, Spokje: Skip  Drupal\Tests\media\...
luenemann’s picture

luenemann
Primary language German
Location Südbaden, Germany
commented
Version: 10.1.x-dev » 10.0.x-dev
dww’s picture

dww
we/he/they
commented

Thanks for skipping this one for now!

FYI, this is still randomly failing in 9x core, too:

https://www.drupal.org/pift-ci-job/2633990

I know we've been keeping these out of 9x as "canary in the coal mine", but it's still causing hassles over there (although that issue is set to 10.1.x, not sure which DrupalCI keeps testing 9.4.x-dev with it...)

xjm’s picture

xjm
she/her
Primary language English
commented

I disagree with the "canary" approach; these issues seriously disrupt the security advisory process as well. So I am backporting it. :)

  • xjm committed 9dae1f73 on 9.5.x authored by longwave 
    Issue #3351494 by catch, Spokje: Skip  Drupal\Tests\media\...

  • xjm committed 842002d5 on 9.4.x authored by longwave 
    Issue #3351494 by catch, Spokje: Skip  Drupal\Tests\media\...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 10.0.x-dev » 9.4.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.