Problem/Motivation

As per Drupal Code Standard, function

bat_type_load(...

was renamed in

bat_unit_type_load(...

Other modules using this feature are required to update the call

CommentFileSizeAuthor
#22 3350936.bat_.d10-2.patch34.91 KBdetroz
#20 3350936.bat_.d10.patch34.91 KBdetroz
#16 bat_type_load_replaced.patch5.46 KBcarlitus
#10 bat.3350936.8.x-2.x-beta1.patch5.61 KBdetroz
#5 bat-3350936-1.patch5.63 KBalina.basarabeanu

Issue fork bat-3350936

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

afagioli created an issue. See original summary.

afagioli’s picture

afagioli
Location Rome
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

alina.basarabeanu’s picture

alina.basarabeanu commented

Can we have this change deployed as a new stable version? Currently, the 8.x-2.1-alpha1 version is not working and the module can't be used.

alina.basarabeanu’s picture

alina.basarabeanu commented
StatusFileSize
new bat-3350936-1.patch5.63 KB

For now, I've created a patch to fix the error across the sub-modules.

afagioli’s picture

afagioli
Location Rome
commented

Thanks Alina,
we will have that with next stable version

alina.basarabeanu’s picture

alina.basarabeanu commented

Hi @afagioli
Why was this ticket closed when there is no new stable version for this module?
I've tried to upgrade bat_api to the latest version but the functionality breaks because there is missing functionality for the bat module.

Alina Basarabeanu opened merge request !4

alina.basarabeanu’s picture

alina.basarabeanu commented

This patch was not fully merged into the 8.x-3.x-dev branch.
The fix for the bat_event and bat_calendar_reference are still missing.

detroz’s picture

detroz commented
StatusFileSize
new bat.3350936.8.x-2.x-beta1.patch5.61 KB

Patch for 8.x-2.x-beta1

afagioli’s picture

afagioli
Location Rome
commented
Status: Closed (fixed) » Needs work
afagioli’s picture

afagioli
Location Rome
commented
Version: 8.x-3.x-dev » 8.x-9.x-dev

working on latest release

afagioli’s picture

afagioli
Location Rome
commented

Function bat_unit_type_load exists inside bat_unit.module

a@silver:~/drupal.org/bat/modules/bat_unit$ git status
On branch 8.x-9.x
Your branch is up-to-date with 'origin/8.x-9.x'.

nothing to commit, working tree clean
a@silver:~/drupal.org/bat/modules/bat_unit$ grep -r 'function bat_unit_type_load' *
bat_unit.module:function bat_unit_type_load($type_id, $reset = FALSE) {
bat_unit.module:function bat_unit_type_load_multiple(array $type_ids, array $conditions, $reset = FALSE) {
a@silver:~/drupal.org/bat/modules/bat_unit$
afagioli’s picture

afagioli
Location Rome
commented
Status: Needs work » Needs review

Carlitus made their first commit to this issue’s fork.

carlitus’s picture

carlitus commented
StatusFileSize
new bat_type_load_replaced.patch5.46 KB

With the 2.1 version this happens yet, and the patch of #10 doesn't work for me.

I've made a change in the MR but it wanted to put in the 2.x version and i don't know how to change, or if tis possible.

I've made a new patch instead.

jwwj’s picture

jwwj commented

Patch in #16 seems to apply OK for me on Drupal 10 and 2.1 version

afagioli’s picture

afagioli
Location Rome
commented

Thanks for contributing.

afagioli’s picture

afagioli
Location Rome
commented
Status: Needs review » Reviewed & tested by the community
detroz’s picture

detroz commented
StatusFileSize
new 3350936.bat_.d10.patch34.91 KB

Even with the patch #16, I had a lot of problems with the version 8.x-2.1 of BAT module : functions not found, accessCheck() missing on queries, "FALSE" instead of "false" in js files, ... and a very unexpected behavior : impossible to upload or see new images.

There is my patch to solve all this things.

afagioli’s picture

afagioli
Location Rome
commented
Status: Reviewed & tested by the community » Needs work
detroz’s picture

detroz commented
StatusFileSize
new 3350936.bat_.d10-2.patch34.91 KB

Little correction in my patch ;)

afagioli’s picture

afagioli
Location Rome
commented

Patch not applying, unfortunately.
Surely evaluating code in it.
Thank for contributing so far

  • afagioli committed c35d280d on 8.x-10.x 
    #3350936 replace bat_type_load with bat_unit_type_load
afagioli’s picture

afagioli
Location Rome
commented

To be noted patch in #22 is facing this tricky issue https://www.drupal.org/project/coding_standards/issues/3259288 also

  • afagioli committed 83347f13 on 8.x-9.x 
    review and apply #3350936#comment-15362269
afagioli’s picture

afagioli
Location Rome
commented
Status: Needs work » Needs review

fixed in https://www.drupal.org/project/bat/releases/8.x-10.x-dev

afagioli’s picture

afagioli
Location Rome
commented
Status: Needs review » Closed (outdated)