Problem/Motivation

Follow-up to #3348851: Deprecate drupal_theme_rebuild()

Let's keep ThemeInstaller code clean unlike other extension subsystem

Proposed resolution

Inject theme registry, themes does not need container rebuild so update should be easy

Remaining tasks

path/review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

CommentFileSizeAuthor
#5 3350904-5.patch3.56 KBandypost
#5 interdiff.txt945 bytesandypost
#4 3350904-4.patch2.64 KBandypost
#4 interdiff.txt1.08 KBandypost
#3 3350904-3.patch2.64 KBandypost
#3 interdiff.txt1.06 KBandypost
#2 3350904-2.patch2.53 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 3350904-2.patch2.53 KB

Here's CR https://www.drupal.org/node/3350906 and patch

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt1.06 KB
new 3350904-3.patch2.64 KB

fixed docs

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt1.08 KB
new 3350904-4.patch2.64 KB

and one more time

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt945 bytes
new 3350904-5.patch3.56 KB

And fix for service

The last submitted patch, 4: 3350904-4.patch, failed testing. View results

dww’s picture

dww
we/he/they
commented

Code looks great. I did some very minor edits to the CR for grammar fixes. I don't believe we need a deprecation test for this. Once the bot is happy, this is RTBC to my eyes.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community

Bot is happy, so am I. 😉

dww’s picture

dww
we/he/they
commented
Title: Properly injected the theme registry in the ThemeInstaller » Properly inject the theme registry in the ThemeInstaller

  • catch committed 7c2e03b9 on 10.1.x 
    Issue #3350904 by andypost, dww: Properly inject the theme registry in...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 7c2e03b and pushed to 10.1.x. Thanks!

dww’s picture

dww
we/he/they
commented

Thanks! Published the CR.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.