Problem/Motivation

Many modules require patches to be able to install them in Drupal 10.

Steps to reproduce

Install Drupal 10
Add guardr_core module and the dependent modules.

Proposed resolution

Update the composer.json file to include the patches until they are merged in.

Remaining tasks

Create an MR
Review the MR

User interface changes

None

API changes

None

Data model changes

None

Issue fork guardr_core-3350324

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

the_g_bomb created an issue. See original summary.

the_g_bomb opened merge request !11

the_g_bomb’s picture

the_g_bomb commented
Status: Active » Needs review

the_g_bomb closed merge request !11

the_g_bomb opened merge request !13

the_g_bomb’s picture

the_g_bomb commented

I struggled rebasing the recent changes to the 2.x branch into the branch I had created initially, too many changes etc. So, I ended up closing the original MR and opening a new one.

I have nearly all the modules from the D7 version in this branch with the exception of 6 which aren’t available to D8/9/10 yet, and a further 7 which are no longer needed. They are outlined in the issue about splitting guardr_core: #3159974-5: Split Guardr into Guardr Core, Guardr Audit, Guardr Extras

the_g_bomb’s picture

the_g_bomb commented

I am now struggling to get guardr_core D10 installed on a project,

I suspect that the lenient allow list doesn't cascade down through the composer dependencies.

I may have to add the various patch forks to get the D10 versions of the modules that don't have a valid release available yet.

the_g_bomb opened merge request !14

the_g_bomb’s picture

the_g_bomb commented

I tried adding the repos to install D10-ready forks, but those didn't pull through on the composer dependencies either.

I have removed the modules that are not yet ready for D10.
These are:
email_confirmer
hacked
logging_alerts
mass_pwreset
paranoia
role_watchdog
state_log
view_profiles_perms
x_originating_ip

The rest have been added.

MR 14 can be tested using:

composer create-project --no-interaction --no-install drupal/recommended-project:^10.0 guardrd10test
cd guardrd10test
composer config repositories.guardr_core vcs git@git.drupal.org:issue/guardr_core-3350324.git
composer require -W drupal/guardr_core:dev-3350324-update-to-D10-minimal
the_g_bomb’s picture

the_g_bomb commented

Still hoping these get merged:
email_confirmer - #3322626: Drupal 10 compatibility
hacked - #3317869: Upgrade code to Drupal 10
logging_alerts - #3190943: User deprecated function: Theme functions are deprecated in drupal:8.0.0 and are removed from drupal:10.0.0. Use Twig templates instead of theme_emaillog_admin_settings()
paranoia - #3289009: Automated Drupal 10 compatibility fixes
role_watchdog - #3297981: Automated Drupal 10 compatibility fixes
state_log - #3289834: Automated Drupal 10 compatibility fixes
view_profiles_perms - #3290410: Automated Drupal 10 compatibility fixes

joestewart made their first commit to this issue’s fork.

joestewart opened merge request !15

joestewart’s picture

joestewart commented

Hi Gareth, thank you for the issue and work!

I created a more minimal MR that didn't add any packages from the Guardr profile.

@Shrop and @Gareth does https://git.drupalcode.org/project/guardr_core/-/merge_requests/15 suffice for Drupal 10?

shrop’s picture

shrop commented

Thanks Joe and Gareth!

I like this and noting we did remove Hacked in this discussion. I think once we have the D10 version released, we can look at the other items around splitting things up more and some other upcoming changes.

I am also thinking we should do Drupal core reqs like this - ^9.3 || ^10 vs. ^9 || ^10 could protect us from dependencies requiring 9.3. We have some now.

shrop’s picture

shrop commented
Status: Needs review » Fixed

Thank to the team here! Great to get this going and talk next steps.

Guardr Core 2.1.0 released.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.