Problem/Motivation

The module is currently non-compatible to Drupal 10, according to the Upgrade status module. Is there a plan for this to be changed?

CommentFileSizeAuthor
#12 address_autocomplete-drupal10-compatibility-3349849-12.patch1.71 KBvaish
#3 Screenshot 2023-03-23 at 4.12.32 PM.png126.14 KBashutosh ahirwal
#2 drupal10-compatible-3349849-2.patch465 bytesashutosh ahirwal

Issue fork address_autocomplete-3349849

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yivanov created an issue. See original summary.

ashutosh ahirwal’s picture

ashutosh ahirwal commented
Priority: Major » Normal
Status: Active » Needs review
Issue tags: +Drupal 10 compatibility
StatusFileSize
new drupal10-compatible-3349849-2.patch465 bytes

Providing patch

ashutosh ahirwal’s picture

ashutosh ahirwal commented
StatusFileSize
new Screenshot 2023-03-23 at 4.12.32 PM.png126.14 KB

For the issue
"The 'address_autocomplete' extension is not installed. Cannot check deprecated library use."
Please make sure that you have added "address" module.

vitor faria’s picture

vitor faria commented

This throws a JS error.

Uncaught TypeError: $(...).once is not a function
at Object.attach (address_autocomplete.js?s2qa25:5:41)

The JS file in this module is not using the once function properly. That needs to be changed for this patch to work.

vitor faria’s picture

vitor faria commented
Status: Needs review » Needs work
chandreshgiri gauswami’s picture

chandreshgiri gauswami commented
Version: 1.0.0-beta1 » 1.0.0-beta2
Assigned: Unassigned » chandreshgiri gauswami
Status: Needs work » Active

Working on it

Chandreshgiri Gauswami opened merge request !8

chandreshgiri gauswami’s picture

chandreshgiri gauswami commented
Assigned: chandreshgiri gauswami » Unassigned
Status: Active » Needs review

Raised an MR with fixes

geoffreyr made their first commit to this issue’s fork.

geoffreyr’s picture

geoffreyr commented

Added the context as the 3rd parameter to the call to once() so whenever Drupal.behaviors.address_autocomplete attaches, it only finds the input.address-line1 that are present within that context, whether it be the document or the AJAXing container or whatever. (as per once change record https://www.drupal.org/node/3158256)

vaish made their first commit to this issue’s fork.

vaish’s picture

vaish commented
StatusFileSize
new address_autocomplete-drupal10-compatibility-3349849-12.patch1.71 KB

Here is the patch that corresponds to the current state of Merge Request !8

justskew made their first commit to this issue’s fork.

vaish’s picture

vaish commented
Version: 1.0.0-beta2 » 1.0.x-dev
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.