Closed (fixed)
Project:
Content Moderation Node Grants
Version:
1.0.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
22 Mar 2023 at 04:37 UTC
Updated:
13 Aug 2025 at 09:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
samitk commentedAbove warning has been fixed.
Comment #5
rassoni commentedComment #6
hardikpandya commentedRTBC for the patch provided by @samit.310@gmail.com. The MR removes the comment entirely which is inappropriate and hence marking this as Needs Work.
Comment #7
rassoni commented@hardikpandya I have removed the code because the code is commented.
PHPCS throw commented code issue which is unnecessary.
Comment #8
avpadernoThe MR is correct: Commented out code should be removed, except in the case the code is planned to be re-added, but in that case there should be a
@todocomment saying that.Comment #9
a.aaronjake commentedHi @Rassoni,
I have applied the changes you committed on MR!2, some errors were still reported. Please see below:
Kindly check
Thanks,
Jake
Comment #10
codebymikey commentedThanks for looking into the issue.
Can the @todo comment be left in for future reference?
Comment #12
avpadernoComment #14
avpadernoComment #15
codebymikey commentedThanks for all the work done on this guy!