Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 3349324-7.patch1003 bytessophiavs

Issue fork session_based_temp_store-3349324

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Vasyl Vasylkiv created an issue. See original summary.

Vasyl Vasylkiv opened merge request !7

ranjit1032002’s picture

ranjit1032002
Primary language English
Location India
commented
Assigned: vasyl vasylkiv » Unassigned
Status: Active » Needs review

MR!7 looks good and working as expected.

hmdnawaz made their first commit to this issue’s fork.

hmdnawaz opened merge request !8

hmdnawaz’s picture

hmdnawaz commented

We should Drupal\Core\Http\RequestStack instead of the Symfony\Component\HttpFoundation\RequestStack according to the

Symfony\Component\HttpFoundation\RequestStack::getMasterRequest() is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0 for Symfony 6 compatibility. Use the forward compatibility shim class Drupal\Core\Http\RequestStack and its getMainRequest() method instead.

MR#8 doest that

sophiavs’s picture

sophiavs commented
StatusFileSize
new 3349324-7.patch1003 bytes

Hi, i tried testing the MR#8, but since the parameter was changed it should also be changed in SessionBasedTempStoreFactory.php and when I tried to change there too the dependency injection was returning a error.

I tried with the MR#7 and it works just as expected! i created a patch to be possible to use while this isn't merged.

nortmas’s picture

nortmas commented
Status: Needs review » Fixed

Thanks. Fixed in a new version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.