Problem/Motivation

  • In the OpenStack Project create form and edit form of SPA, when I fill out Member form properly and click the "Save" button, the openstack project is saved correctly.
    • This can be resolved by changing the name from role to roles
  • The value of the form should be the Drupal EntityID, not the same value as the label.
  • Role must be able to be selected multiple.

Issue fork cloud-3349074

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hosomitm created an issue. See original summary.

hosomitm opened merge request !1668

hosomitm’s picture

hosomitm commented
Status: Active » Needs review

@yas @ryo-yamashita

Please review the code. Thank you.

yas made their first commit to this issue’s fork.

ryo yamashita’s picture

ryo yamashita commented

@yas

It looks good to me. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for your review.

@hostomitm

I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@hosotmi

I found we should have some refactoring during my final check. Can you please see my comment? Thanks!

hosomitm’s picture

hosomitm commented
Status: Needs work » Needs review

@yas

Thank you for your review.

I fixed it you pointed out.
Please review again.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@hostomitm

Thank you for the update. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 0830ad21 on 5.x authored by hosomitm 
    Issue #3349074 by hosomitm, yas, Ryo Yamashita: Fix the OpenStack...

Ryo Yamashita opened merge request !1678

Ryo Yamashita opened merge request !1679

ryo yamashita’s picture

ryo yamashita commented

@yas

I created 3349074-fix-the-openstack-4x branch and pushed the patch. Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@ryo-yamashita

Thank you for creating the patch. I'll merge the patch to 4.x, and close this issue as Fixed.

yas closed merge request !1679

  • yas committed aa96efb1 on 4.x authored by Ryo Yamashita 
    Issue #3349074 by yas, hosomitm, Ryo Yamashita: Fix the OpenStack...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.