Problem/Motivation

    Refactor OpenStack network interface
  • (Remove entity type openstack_network_interface)

Issue fork cloud-3348610

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !1663

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the refactoring. Can you please fix the following coding standard error? Thanks

FILE: ...e_providers/openstack/src/Service/OpenStackOperationsService.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 2754 | WARNING | Unused private method saveNetworkInterface()
----------------------------------------------------------------------
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Refactor OpenStack network interface (4) (Remove entity type openstack_network_interface) » Refactor OpenStack network interface (Remove entity type openstack_network_interface)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

Can you please rebase the patch? Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Please review the code. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the update; and sorry, can you please rebase the patch again due to the previous merge?

Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. I'll try to merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 4b97ce64 on 5.x authored by Xiaohua Guan 
    Issue #3348610 by Xiaohua Guan, yas: Refactor OpenStack network...

  • yas committed cdb06e68 on 4.x authored by Xiaohua Guan 
    Issue #3348610 by Xiaohua Guan, yas: Refactor OpenStack network...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.