Closed (fixed)
Project:
Drupal core
Version:
10.1.x-dev
Component:
user.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Mar 2023 at 09:32 UTC
Updated:
11 Apr 2023 at 14:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexpottThere no need to postpone this.
Comment #3
ranjit1032002Uploaded a patch for the issue mentioned, please review.
Thank You.
Comment #4
alexpottThis function shouldn't be changing at all. It will be reomved in Drupal 11.
This code should be removed because we change the PermissionsHashGenerator
Comment #5
alexpottHere's the deprecations and the uses in core replaced. Now we need to add test coverage of the deprecated methods. To test the deprecation and to ensure we don't break them until they are removed.
No interdiff because of #4.
Comment #6
smustgrave commentedMoving back to NW for the failures in https://dispatcher.drupalci.org/job/drupal_patches/172699/console
Comment #7
andypostfix failure
Comment #8
smustgrave commentedThanks @andypost!
Change looks good to me. Only moving to NW for the deprecation tests of the functions that were deprecated. per #5
Comment #9
andypostAdded test
Comment #10
andypostand clean-up
Comment #11
andypost2 more typos
Comment #12
smustgrave commentedTest coverage looks good.
Comment #13
alexpottWe need to complete the issue summary and change record.
Comment #14
andypostupdated IS and CR also fixed nit in patch
Comment #15
smustgrave commentedWonder if we could provide examples in the CR for _user_role_permissions_update also please.
Comment #16
andypostAdded to CR that
_user_role_permissions_update()has no replacements (it was not API as function name starts with underscore) and config should not be read directlyComment #17
smustgrave commentedThanks!
Comment #18
catchCommitted/pushed to 10.1.x, thanks! Nice to see constructor property promotion here.
Comment #19
catchComment #20
andypostLooks not pushed and CR is not published
Comment #22
catchOops, now pushed and CR published.