Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 3348050-6.patch7.14 KBtonytheferg
#5 3348050-5.patch6.74 KBtonytheferg
#2 3348050-2.patch1.54 KBgayatri chahar

Issue fork commerce_quick_ship_form-3348050

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gayatri chahar created an issue. See original summary.

gayatri chahar’s picture

gayatri chahar commented
Assigned: gayatri chahar » Unassigned
Status: Active » Needs review
StatusFileSize
new 3348050-2.patch1.54 KB

Patch created. Please review it

_pratik_ made their first commit to this issue’s fork.

_pratik_ opened merge request !1

tonytheferg’s picture

tonytheferg commented
Title: t() calls should avoided in class » Clean up coding standards
StatusFileSize
new 3348050-5.patch6.74 KB

Lets clean up all the coding standards in one issue.

tonytheferg’s picture

tonytheferg commented
StatusFileSize
new 3348050-6.patch7.14 KB

  • tonytheferg committed 7b2a08cb on 1.0.x 
    Issue #3348050 by tonytheferg, _pratik_, gayatri chahar: Clean up coding...
tonytheferg’s picture

tonytheferg commented

Committing this, and we can add a commit when 402 is fixed, or if anything else is found.

line 402: Only string literals should be passed to t() where possiblephpcs

  • tonytheferg committed 98258752 on 1.0.x 
    Issue #3348050 by tonytheferg: Clean up coding standards
tonytheferg’s picture

tonytheferg commented
Status: Needs review » Fixed
tonytheferg’s picture

tonytheferg commented
Status: Fixed » Closed (fixed)
tonytheferg’s picture

tonytheferg commented