Closed (fixed)
Project:
Manage display
Version:
3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Mar 2023 at 11:04 UTC
Updated:
16 Oct 2024 at 10:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sahana _n commentedComment #5
sahil.goyal commentedThanks @Sahana _N, the implemented hook looks great, patch applies cleanly, Created MR for easy merging, Moving to RTBC
Comment #6
adamps commentedThanks, good idea and it's a good start. However the help is rather short, and it doesn't tell you much😃. I plan to write a docs page soon, so maybe after I've done that it will help with this issue.
Please put the help function at the end of the file, as it's not normally looked at during development. There is a typo "his project".
The MR seems a bit mixed up.
Comment #8
urvashi_vora commentedHi @AdamPS,
Based on your feedback
For now, I have updated the existing MR and moved the help function at the end of file and also corrected the typo "his project".
Moving it to Needs Review. Please verify the changes.
Thanks
Comment #9
paraderojether commentedHi @urvashi_vora
I reviewed the MR and the changes are verified, and it's working fine for me.
Moving this to RTBC.
Please look at the screenshot for reference. Thank You.
Comment #10
adamps commentedThanks. The MR is against the wrong branch - it needs to be on 3.x. I think the solution is to create a new MR.
I have now created a docs page. Some of this information should be added into the help text
Comment #11
raveen_thakur51 commentedHello Folks.
I have reviewed & Implemented the MR! on my Drupal website having version 9.5, PHP version - 8.1
The hook_help has been implemented successfully.
I am attaching my patch (before,after,typosfixed.png) & screenshots for reference. Please have a look.
Please & Thank You.
Comment #12
adamps commentedComment #13
elberHi moving to RTBC
patch#11 passed in the tests
Is applied cleanly
is following phpcs
Exlpalin the module
Comment #14
raveen_thakur51 commented@elber, Thanks for confirmation.
Comment #16
astonvictor commentedComment #18
astonvictor commentedCreated a new MR with
hook_help().Comment #19
adamps commentedGreat that's a big improvement thanks.
1) I feel that the comments at the top of the formatter classes are good for submitted and reply-to (perhaps I'm biased as I wrote them😃). Please could we use those? They include a simple reference to the templates so we could then drop the templates section, which currently feel a bit technical for the display in the UI.
2) Please could we make Formatters also a h3?
Comment #20
raveen_thakur51 commented.
Comment #21
astonvictor commentedComment #22
adamps commentedThanks. The comments I mean are these. They give a rough indication of the template without too much detail and describes the default value. What do you think?
* Formats a user reference as a sentence including the date, with an optional
* user picture. The sentence is determined by the 'submitted' template, with a
* default of "Submitted by on ".
AND
* Formats a comment reference as a sentence including the subject and author.
* The sentence is determined by the 'in-reply-to' template, with a
* default of "In reply to by ".
Comment #23
adamps commentedI have very little time now for Drupal, so I will try to leave you as much freedom as possible. Either this or the first one are fine whatever you prefer.
Comment #24
astonvictor commented