First, thanks for making this module available on d.o .
Problem/Motivation
It would be great to fix all the PHPCS issues:
I listed a few issues below. A complete set of issues is available in the attached file.
FILE: /var/www/html/web/modules/custom/xtc/src/PluginManager/XtcFieldType/XtcFieldTypeInterface.php
---------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------
11 | ERROR | [x] Opening brace should be on the same line as the declaration
12 | ERROR | [x] Missing function doc comment
12 | ERROR | [x] Expected 1 blank line before function; 0 found
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------
FILE: /var/www/html/web/modules/custom/xtc/src/PluginManager/XtcFieldType/XtcFieldTypePluginBase.php
----------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------
15 | ERROR | Missing parameter comment
16 | ERROR | Missing parameter comment
16 | ERROR | Missing parameter type
17 | ERROR | Missing parameter comment
17 | ERROR | Missing parameter type
19 | WARNING | Possible useless method overriding detected
----------------------------------------------------------------------------------------------------
FILE: /var/www/html/web/modules/custom/xtc/src/PluginManager/XtcRequest/XtcRequestPluginManager.php
---------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------
14 | WARNING | Line exceeds 80 characters; contains 83 characters
33 | WARNING | Line exceeds 80 characters; contains 84 characters
---------------------------------------------------------------------------------------------------
FILE: /var/www/html/web/modules/custom/xtc/src/PluginManager/XtcServer/XtcServerPluginManager.php
-------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------
14 | WARNING | Line exceeds 80 characters; contains 81 characters
33 | WARNING | Line exceeds 80 characters; contains 83 characters
-------------------------------------------------------------------------------------------------
FILE: /var/www/html/web/modules/custom/xtc/src/PluginManager/XtcHandler/XtcHandlerInterface.php
-----------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------
11 | ERROR | [x] Opening brace should be on the same line as the declaration
21 | ERROR | [x] Missing function doc comment
23 | ERROR | [x] Missing function doc comment
25 | ERROR | [x] Missing function doc comment
27 | ERROR | [x] Missing function doc comment
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------
Steps to reproduce
Run the command for the list of PHPCS issues.
phpcs --standard="DrupalPractice,DrupalStandard" xtc
Proposed resolution
Resolve all the issues. phpcs-issues.txt
Remaining tasks
User interface changes
API changes
Data model changes
Comments
Comment #3
arunkumarkCreated MR by resolving a few minor issues. Need to resolve remaining valid PHPCS issues.
https://git.drupalcode.org/project/xtc/-/merge_requests/2
Comment #4
kunal_sahu commentedComment #5
kunal_sahu commentedHi I could reproduce the issue's there are many PHPCS issue.
Will create an MR to resolve all issues. Thanks
Comment #6
kunal_sahu commentedHi I have fixed all issues with proper commenting to every file.
I have litreally solved these many issues and made sure add proper comment to my understanding.
But there are some Line exceeds 80 characters; for which i have created another Issue. https://www.drupal.org/project/xtc/issues/3347198 .
Please review and ,merge this MR .
Thanks
Comment #8
avpadernoComment #9
nisha_j commentedHi, I reviewed the MR and there are Line exceeds 80 characters error in .md files that needs to be fixed.
Thankyou.
Comment #12
mohd sahzad commentedHi @sashainparis,
I have fixed the Line exceeds 80 characters error in .md files, so please review MR !2
Comment #13
yashaswi18 commentedHello, after checking out to the branch '3347143-phpcs' and running the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig xtc/. Found no errors or warnings remaining.
Comment #14
adwivedi008 commentedTested the coding standard issue using the following command
Seems MR #12 resolved the coding standard issue
So moving the issue to RTBC.
Comment #15
adwivedi008 commented