Problem/Motivation

  • Refactor the Floating network ID field in the OpenStack floating IP create form in SPA.

Issue fork cloud-3347138

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !1642

sekinet’s picture

sekinet commented
Status: Active » Needs review

@yas

Could you please review the patch?

yas made their first commit to this issue’s fork.

ryo yamashita’s picture

ryo yamashita commented

@sekinet @yas

It looks good to me. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for your review.

@sekinet

I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 4a0b8684 on 5.x authored by sekinet 
    Issue #3347138 by sekinet, yas, Ryo Yamashita: Refactor the Floating...

  • yas committed 31b93025 on 4.x authored by sekinet 
    Issue #3347138 by sekinet, yas, Ryo Yamashita: Refactor the Floating...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.