Needs review
Project:
Shortcut Menu
Version:
3.0.0-beta3
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Mar 2023 at 03:52 UTC
Updated:
20 Aug 2024 at 19:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
samitk commentedAbove error/warnings has been fixed.
Comment #3
hardikpandya commentedThe patch fixes all phpcs issues. Marking RTBC!
Comment #5
avpadernoWhat does the
phpcsreport say about that line?What is wrong with those lines?
That is not a necessary change, except in the case the code is already using
$entityTypeManager.Comment #8
kunalgautam commentedComment #9
avpadernoThat does not describe what the class does, nor does it make sense.
Parameters and return value need to be documented.
Comment #10
elberI will work on it.
Comment #11
elberHi I fixed the errors mentioned previously, please revise.
Comment #12
a.aaronjake commentedHi @elber,
Applied the latest changes made on MR!2, it was applied successfully but one file with 2 errors were still reported. Please see below:
Kindly check
Thanks,
Jake
Comment #15
avpadernoComment #17
avpadernoThere are still two PHP_CodeSniffer errors to fix.
Comment #18
avpadernoComment #19
avpadernoComment #20
avpadernoComment #21
avpadernoMR !2 fixes all the PHP_CodeSniffer errors/warnings reported by GitLab CI.