CommentFileSizeAuthor
#2 3347117-2.patch2.69 KBsamitk
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

samit.310@gmail.com created an issue. See original summary.

samitk’s picture

Assigned: samitk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new2.69 KB

Above error/warnings has been fixed.

hardikpandya’s picture

Status: Needs review » Reviewed & tested by the community

The patch fixes all phpcs issues. Marking RTBC!

avpaderno’s picture

Title: Drupal Coding Standards Issues | phpcs » Fix the issues reported by phpcs
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work
Issue tags: -Coding standards Phpcs, -Phpcs Drupal coding standard issue
 /**
- * Class ShortcutMenuSetCustomize.
+ * The ShortcutMenuSetCustomize Class.

What does the phpcs report say about that line?

+/**
+ * The ShortcutMenuLazyBuilder Class.
+ */

What is wrong with those lines?

-  protected $entity_type_manager;
+  protected $entityTypeManager;

That is not a necessary change, except in the case the code is already using $entityTypeManager.

kkalashnikov made their first commit to this issue’s fork.

kunalgautam’s picture

Status: Needs work » Needs review
avpaderno’s picture

Status: Needs review » Needs work
 /**
- * Class ShortcutMenuSetCustomize.
+ * The set customization for shortcut menu.

That does not describe what the class does, nor does it make sense.

+  /**
+   * Gets the Parent id from UUID.
+   */

Parameters and return value need to be documented.

elber’s picture

Assigned: Unassigned » elber

I will work on it.

elber’s picture

Assigned: elber » Unassigned
Status: Needs work » Needs review

Hi I fixed the errors mentioned previously, please revise.

a.aaronjake’s picture

Status: Needs review » Needs work

Hi @elber,

Applied the latest changes made on MR!2, it was applied successfully but one file with 2 errors were still reported. Please see below:

➜  shortcut_menu git:(main) ✗ curl https://git.drupalcode.org/project/shortcut_menu/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3125    0  3125    0     0   6552      0 --:--:-- --:--:-- --:--:--  6706
patching file shortcut_menu.install
patching file src/Form/ShortcutMenuSetCustomize.php
patching file src/ShortcutMenuLazyBuilder.php
➜  shortcut_menu git:(main) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig shortcut_menu

FILE: /Users/PrometInterns/Demo-site/drupal-orgissue/web/modules/contrib/shortcut_menu/src/Form/ShortcutMenuSetCustomize.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------
 177 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 196 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

Time: 266ms; Memory: 10MB

Kindly check

Thanks,
Jake

avpaderno changed the visibility of the branch 3347117-phpcs-fixes to hidden.

avpaderno’s picture

Issue summary: View changes

avpaderno changed the visibility of the branch 3347117-gitlab-ci-reports to hidden.

avpaderno’s picture

avpaderno’s picture

Assigned: Unassigned » avpaderno
avpaderno’s picture

Status: Needs work » Needs review
avpaderno’s picture

Assigned: avpaderno » Unassigned
avpaderno’s picture