Problem/Motivation

We could be using README.md instead of README.txt to make use of the nicer rendering via markdown.

CommentFileSizeAuthor
#12 3347116 - with MR.png359.36 KBkenyoowen
#12 3347116 - applying MR.png118.1 KBkenyoowen
#8 3347116 - #6.png380.82 KBkenyoowen
#6 3347116-6.patch2.21 KBnitin_lama
#4 3347116 - after.png246.67 KBkenyoowen
#4 3347116 - before.png246.49 KBkenyoowen
#2 3347116-2.patch1.45 KBsamitk

Issue fork telegram_media_type-3347116

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

samit.310@gmail.com created an issue. See original summary.

samitk’s picture

samitk commented
Assigned: samitk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3347116-2.patch1.45 KB

Issue fixed.

kenyoowen’s picture

kenyoowen commented
Status: Needs review » Needs work

Hi samit.310@gmail.com

I reviewed and apply your patch and the README.txt isn't replaced with README.md. And it also missing some information, please update it according to README.md template

Please see the screenshots attached.
Thank you.

kenyoowen’s picture

kenyoowen commented
StatusFileSize
new 3347116 - before.png246.49 KB
new 3347116 - after.png246.67 KB
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review
StatusFileSize
new 3347116-6.patch2.21 KB

Updated patch as per README.md template. Please review.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
kenyoowen’s picture

kenyoowen commented
Status: Needs review » Needs work
StatusFileSize
new 3347116 - #6.png380.82 KB

Hi nitin_lama

I applied and reviewed your patch and the README.md is present but the README.txt is not removed which is redundant to the module.

Please see the screenshots attached.
Thank you.

elber made their first commit to this issue’s fork.

elber opened merge request !1

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs work » Needs review

Hi I fixed it please revise.

kenyoowen’s picture

kenyoowen commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3347116 - applying MR.png118.1 KB
new 3347116 - with MR.png359.36 KB

Hi elber

I applied your MR and confirmed that README.txt is replaced with README.md.
Please see the screenshots attached.

Thank you.

kaszarobert’s picture

kaszarobert
Primary language Hungarian
commented
Status: Reviewed & tested by the community » Fixed

I committed. Thanks everyone for the work!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.