Problem/Motivation

The $tempStore property on Drupal\Core\Action\Plugin\Action\DeleteAction is type hinted as \Drupal\Core\TempStore\SharedTempStore, but it should be \Drupal\Core\TempStore\PrivateTempStore since it's constructed by Drupal\Core\TempStore\PrivateTempStoreFactory.

Proposed resolution

Change the type hint.

Issue fork drupal-3347019

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DieterHolvoet created an issue. See original summary.

DieterHolvoet opened merge request !3619

dieterholvoet’s picture

dieterholvoet commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

This was actually fixed in #3135038: Fix change SharedTempStore to PrivateTempStoreFactory on the DeleteAction will leave a comment there if it should be backported.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

dieterholvoet’s picture

dieterholvoet commented
Status: Needs work » Closed (outdated)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.