Problem/Motivation

  • The breadcrumbs displayed on each SPA view are hyperlinks.

Issue fork cloud-3346876

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hosomitm created an issue. See original summary.

hosomitm opened merge request !1640

hosomitm’s picture

hosomitm commented
Status: Active » Needs review

@yas @ryo-yamashita

Please review the code. Thank you.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@hosomitm

Thank you for the patch. It looks good.

@ryo-yamashita

What do you think?

Thanks

Ryo Yamashita’s picture

Ryo Yamashita commented

@hosomitm @yas

It looks good, but I have added some comments. Please check them. Thanks.

hosomitm’s picture

hosomitm commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for your review.
I will fix the problem you pointed out.

hosomitm’s picture

hosomitm commented
Status: Needs work » Needs review

@yas @ryo-yamashita

I fixed it you pointed out.
Please review again.

Ryo Yamashita’s picture

Ryo Yamashita commented

@hosomitm

It looks good to me. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for your review.

@hostomitm

I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 9b2a01f8 on 5.x authored by hosomitm 
    Issue #3346876 by hosomitm, yas, Ryo Yamashita: Add a hyperlink to the...

  • yas committed 1829a7b1 on 4.x authored by hosomitm 
    Issue #3346876 by hosomitm, yas, Ryo Yamashita: Add a hyperlink to the...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.