Number routes, specifically :
entity.group.canonicalentity.group.version_historyview.group_members.page_1view.group_nodes.page_1are ignoring "Use admin theme" configuration option and showing front end theme.
Tested on Drupal 9.5.3 and latest 3.x group on 8cefda266dedfc6657dee736780400cc1a8d00d6 commit.
Fix the bug
None
None
None
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | group-admin-theme-revisions-history-3346626-9.patch | 1.32 KB | p-neyens |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !319compare compare changes, plain diff MR !165
Comments
Comment #2
kristiaanvandeneyndeYou want your group canonical route to be a landing page so displaying that in the admin theme makes little sense. The other routes I could agree with, but I never really triggered it for the members and nodes view because of #2719797: New option for Views page displays to use the admin theme
Not really a bug report as it boils down to personal preference and what makes the most sense.
Comment #3
kristiaanvandeneyndeThe core issue only just landed in 10.1 so we will have to wait for 9.x support to be dropped before we can start using that. entity.group.version_history now shows in admin theme, so I see no actionable items here until Drupal 10 is the minimum supported core version.
Comment #6
s_leu commentedThis seems a to work only randomly depending on the apparently random order of route subscribers, which in you case seemed to be correct. The order seems to be different in my case and to ensure that the admin theme is used, we need the altering in
GroupRevisionRouteSubscriberto run before the one inGroupAdminRouteSubscriber. A corresponding change can be found in the MR.Btw. I wasn't sure which target branch to use, please change it if it's incorrect.
Comment #7
kristiaanvandeneyndeI would do it the other way around and make the admin subscriber run really late, rather than the revision subscriber run early. This way we don't get the same bug when new route subscribers are introduced.
We should also update the default views and write an update hook to make sure existing installs get the same update.
Comment #8
gwvoigtI think this would be very useful. The patch worked for me in the lats release of Group 3.3.5. I can't see why the revisions list would not be using Admin theme by default.
Comment #9
p-neyens commentedThe patch worked for me in the 2.3.2 release of Group.
I also provide the patch file to use with composer-patches.
Comment #10
kristiaanvandeneyndeSee #7, the admin subscriber should be running late, not other subscribers running early.
Also the minimum core version is now 10+, so it's also actionable to update the views. For that, I'd need to see "use_admin_theme: true" on both views mentioned in the issue summary + an update hook.
Comment #15
kristiaanvandeneyndeActually, GroupAdminRouteSubscriber alters the route options in a non-destructive way. It only touches the _admin_route option. GroupLatestRevisionRouteSubscriber touches the route requirements, but not options. So I have no clue where the claim comes from that they interfere with each other, they shouldn't.
So just adjusting the views should do enough. If not, then we really need to look into why it's misbehaving and that would be a bug report of its own.
Comment #16
kristiaanvandeneyndeMR updates the views to use the admin theme, please check.
Comment #17
kristiaanvandeneyndeOkay going to commit this as such due to lack of feedback. If people are still struggling with entity.group.canonical or entity.group.version_history, then please open a new issue.