Problem/Motivation

Getting following error/warnings.

FILE: /var/www/html/modules/contrib/focal_point_focus/focal_point_focus.module
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
11 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
33 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/modules/contrib/focal_point_focus/src/Plugin/Field/FieldFormatter/FocalPointFocusFormatter.php
------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------
34 | ERROR | Parameter $focal_point_manager is not described in comment
51 | ERROR | Doc comment for parameter $focal_point does not match actual variable name $focal_point_manager
------------------------------------------------------------------------------------------------------------------

Time: 912ms; Memory: 6MB

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/focal_point_focus/

Proposed resolution

Above error/warnings need to be fixed.

CommentFileSizeAuthor
#2 3346406-2.patch2.21 KBsamitk
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

samit.310@gmail.com created an issue. See original summary.

samitk’s picture

Assigned: samitk » Unassigned
Status: Needs work » Needs review
StatusFileSize
new2.21 KB

Above error/warnings are fixed.

hardikpandya made their first commit to this issue’s fork.

hardikpandya’s picture

Status: Needs review » Reviewed & tested by the community

The patch resolved all phpcs issues. There was one update needed with

/**
- * Implements of hook_help().
+ * Implements hook_example().
 */

I have fixed it as well. Marking RTBC!

skaught’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: -, -

v2 line now release. this would needs to be updated..

  • SKAUGHT committed 35e74ad8 on 2.0.x
    Issue #3346406 by samit.310@gmail.com: Drupal Coding Standards Issues |...
skaught’s picture

Status: Needs work » Fixed

dev2.0.x pushed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.