Problem/Motivation

  • In the list view of Drupal forms, the button to refresh the list of entities behaved strangely when using OpenStack entities.
  • The cause has been identified and fixed.

Issue fork cloud-3346196

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1631

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. I posted my comment. Thanks!

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
ryo yamashita’s picture

ryo yamashita commented

@yas

I pushed a new patch. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. It looks good. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 201d75f6 on 5.x authored by Ryo Yamashita 
    Issue #3346196 by Ryo Yamashita, yas: Fix an error when updating the...

  • yas committed 44eb59a4 on 4.x authored by Ryo Yamashita 
    Issue #3346196 by Ryo Yamashita, yas: Fix an error when updating the...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

@ryo-yamashita

I found that there were some coding violations as follows. Can you please create the hotfix? Thanks

FILE: ...oud_service_providers/openstack/src/Controller/ApiController.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 469 | ERROR | [x] Case breaking statements must be followed by a
     |       |     single blank line
 472 | ERROR | [x] Case breaking statements must be followed by a
     |       |     single blank line
 475 | ERROR | [x] Case breaking statements must be followed by a
     |       |     single blank line
----------------------------------------------------------------------

Ryo Yamashita opened merge request !1638

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I pushed a hotfix. Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. Can you please fix the following coding standard error, too?

FILE: ...oud_service_providers/openstack/src/Controller/ApiController.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 460 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
----------------------------------------------------------------------
ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I pushed a hotfix, too. Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. It looks good. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed c98b950a on 5.x authored by Ryo Yamashita 
    Issue #3346196 by Ryo Yamashita, yas: Hotfix - Fix an error when...

  • yas committed ba97dfba on 4.x authored by Ryo Yamashita 
    Issue #3346196 by Ryo Yamashita, yas: Hotfix - Fix an error when...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.