Closed (fixed)
Project:
IEF Complex Open Widget
Version:
1.0.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Mar 2023 at 06:07 UTC
Updated:
7 Sep 2024 at 01:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
arunkumarkNeed to fix remaining Coding standard issues.
Comment #4
aakansha tyagi commentedComment #5
aakansha tyagi commentedI have fixed the above coding standards issues. Please review it.
Comment #6
bindu r commentedHi, patch #5 applied cleanly, fixing most of the errors. One error still needs to be fixed.
Comment #8
mlncn commentedComment #10
nilesh.addweb commentedHi,
I have fixed remaining phpcs issues and fixed conflict from upstream. please review it.
Comment #11
riddhi.addweb commentedThe mentioned phpcs issue is resolved, & I have also checked and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.
Comment #12
riddhi.addweb commentedIgnore this Screenshot
Comment #15
mlncn commentedI'm giving credit on this issue but not taking a lot of the changes. Maybe someone can explain while i should care someday but until then i am not making perfectly readable 89 character lines into three less readable ones because phpcs tells me too.
A fair number of the warnings appear to be at odds with Drupal's coding standards (not allowing inline doc block comments that start with
/**??)For modules i maintain please check with me before undertaking these sorts of patches, please.
(The merge request also commented out a couple variables which is absolutely not OK in a formatting patch!)