Problem/Motivation

FILE: /var/www/html/web/modules/custom/ief_popup/ief_popup.module
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  43 | ERROR   | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
  94 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
  98 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 119 | ERROR   | [ ] All functions defined in a module file must be prefixed with the module's name, found "_process_ief_form" but expected "ief_popup__process_ief_form"
 119 | ERROR   | [ ] Type hint "array" missing for $ief_form
 119 | ERROR   | [ ] Type hint "array" missing for $parameters
 215 | ERROR   | [x] Short array syntax must be used to define arrays
 229 | ERROR   | [ ] All functions defined in a module file must be prefixed with the module's name, found "_ief_form_after_build" but expected "ief_popup__ief_form_after_build"
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/ief_popup/ief_popup.libraries.yml
------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------
 12 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

Steps to reproduce

Run the command phpcs --standard="DrupalPractice,Drupal" ief_popup

Proposed resolution

Resolve coding standard issue and create the patch.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 3346171-5.patch2.58 KBimustakim

Issue fork ief_popup-3346171

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 8.x-2.x Comparecompare

Comments

arunkumark created an issue. See original summary.

arunkumark’s picture

Assigned: arunkumark » Unassigned
Status: Active » Needs work

Need to fix remaining Coding standard issues.

dataweb’s picture

I plan to deploy the pending issues next week.

imustakim’s picture

Assigned: Unassigned » imustakim

Working on this.

imustakim’s picture

Assigned: imustakim » Unassigned
Status: Needs work » Needs review
StatusFileSize
new2.58 KB

Patch added.
Please review.

omkar_yewale’s picture

Assigned: Unassigned » omkar_yewale
omkar_yewale’s picture

Assigned: omkar_yewale » Unassigned
Status: Needs review » Reviewed & tested by the community

Thanks for the patch, All phpcs issues/warnings are fixed.
Marking as RTBC.

  • dataweb committed a2d96856 on 2.x
    #3346171: Fix the issues reported by phpcs
    
dataweb’s picture

Version: 2.0.0-beta1 » 2.0.0-beta2
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.