Problem/Motivation

#3345227: Fix Drupal 10 - PHP Fatal error: Type of ChecklistapiCommands::$logger must be LoggerInterface

PHP Fatal error:  Declaration of Drupal\varbase_update_helper\Commands\VarbaseUpdateHelperCommands::setLogger(Psr\Log\LoggerInterface $logger) must be compatible with Drush\Commands\DrushCommands::setLogger(Psr\Log\LoggerInterface $logger): void in /var/www/html/test/varbase10t1test1/docroot/modules/contrib/varbase_core/modules/varbase_update_helper/src/Commands/VarbaseUpdateHelperCommands.php on line 35

Change records

Update code that implements \Psr\Log\LoggerInterface due to Psr/Log version 3
#3272447: Update to PSR/log v3
#3264918: Update symfony/console to Symfony 6

Proposed resolution

Remove the setLogger as it was change from the Drush Logger system.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.0-alpha1, varbase_core-10.0.0-alpha1

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3345236: Fixed Drupal 10 - PHP Fatal error: Declaration of Varbase Update Helper Commands setLogger must be compatible with Drush Commands setLogger

Comments

Rajab Natshah created an issue. See original summary.

  • Rajab Natshah committed 9c269c3d on 10.0.x
    Issue #3345236: Fix Drupal 10 - PHP Fatal error:  Declaration of Varbase...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase-10.0.0-alpha1, +varbase_core-10.0.0-alpha1
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes