Problem/Motivation

  • Fix submit button label that attach network interface to an OpenStack instance in SPA to "Attach Interface".

Issue fork cloud-3345154

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hosomitm created an issue. See original summary.

hosomitm opened merge request !1624

hosomitm’s picture

hosomitm commented
Status: Active » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@hosomitm

Thank you for the patch. I posted my comment. Thanks

hosomitm’s picture

hosomitm commented
Status: Needs work » Needs review

@yas

Thank you for your review.
Could you please confirm again whether it really needs to be corrected to lower case?
If I change to lower case, I would like to make a similar change to the Detach Interface label.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
hosomitm’s picture

hosomitm commented
Status: Needs work » Needs review

@yas

Fixed case sensitivity.
Please review again.
Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Fix submit button label that attach network interface to an OpenStack instance in SPA » Fix the submit button label that attach network interface to an OpenStack instance in SPA
Status: Needs review » Reviewed & tested by the community

@hosomitm

Thank you for the update. It looks good to me now. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 9d5d84c3 on 5.x authored by hosomitm 
    Issue #3345154 by hosomitm, yas: Fix the submit button label that attach...

  • yas committed 2275de85 on 4.x authored by hosomitm 
    Issue #3345154 by hosomitm, yas: Fix the submit button label that attach...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.