Problem/Motivation

  • Create form for detaching a network interface from an OpenStack instance entity.

Issue fork cloud-3344882

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hosomitm created an issue. See original summary.

hosomitm opened merge request !1619

hosomitm’s picture

hosomitm commented
Status: Active » Needs review

@yas

Please review it. Thanks.

ryo yamashita’s picture

ryo yamashita commented
Status: Needs review » Needs work

@hosomitm

It looks good to me. However, I was curious about some of the issues and left a comment. Thanks.

hosomitm’s picture

hosomitm commented
Status: Needs work » Needs review

@yas @ryo-yamashita

I corrected submit button label to "Detach Interface".
Could you please review this again.
Thanks.

ryo yamashita’s picture

ryo yamashita commented

@hosomitm

Thank you for your additional commit. It looks good.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashiya

Thank you for your review.

@hosomitm

I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 9730a038 on 5.x authored by hosomitm 
    Issue #3344882 by hosomitm, yas, Ryo Yamashita: Add the function to...

  • yas committed 3cbd6430 on 4.x authored by hosomitm 
    Issue #3344882 by hosomitm, yas, Ryo Yamashita: Add the function to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.