Part of #3299855: [META] Get rid of #[\AllowDynamicProperties] attribute
There's a set of undefined properties muted with attribute, it should be defined and attribute removed
From #3295821-94: Ignore: patch testing issue for PHP 8.2 attributes
+ protected $langcode;
+ protected $pass;
+ protected $status;
+ protected $created;
+ protected $changed;
+ protected $login;
+ protected $init;
+ protected $default_langcode;
+ protected $content_translation_source;
+ protected $content_translation_outdated;
+ protected $content_translation_uid;
+ protected $content_translation_status;
+ protected $content_translation_created;
+ protected $rest_test_validation;
+ public $pass_raw;
+ public $passRaw;
+ public $sessionId;
define all missing properties, refactor test code if it using object without reason
- agree
- patch/review/commit
no
no
no
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3344729-2.patch | 1.04 KB | andypost |
Comments
Comment #2
andypostall properties
Comment #3
ranjit1032002I had Reviewed the patch and it's working as expected mentioned in comment #2
Comment #4
andypostAt least half of this properties are externally set by rest and content translation modules - needs refactoring of usage, removal of dynamic access or replacing userSession with real User entity
Comment #5
berdirThat (using user entity) won't be enough. The user password stuff is drupalLogin() related and will likely require is to refactor that to avoid storing arbitrary stuff on either UserSession or content entities, these are just hiding the problem for now.